Issue 564013002: Revert 181758 "Simplify DOMWindowProperty and its unregistration."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 564013002: Revert 181758 "Simplify DOMWindowProperty and its unregistration." (Closed)

Created:
6 years, 3 months ago by haraken

Modified:
6 years, 3 months ago

Reviewers:
sof

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

Revert 181758 "Simplify DOMWindowProperty and its unregistration." This CL caused use-after-free in :LocalDOMWindow::willDetachDocumentFromFrame. https://code.google.com/p/chromium/issues/detail?id=413316 > Simplify DOMWindowProperty and its unregistration. > > As LocalDOMWindow controls the registration lifetime of its > DOMWindowProperties, there's no need to offer a separate unregistration > mechanism. Remove it, simplify notification code + retire now unused > LocalDOMWindow back reference on DOMWindowProperty. > > R=haraken,ager > BUG= > > Review URL: https://codereview.chromium.org/558213002 TBR=sigbjornf@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181867

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -13 lines)			Patch
M	trunk/Source/core/frame/DOMWindowProperty.h	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	trunk/Source/core/frame/DOMWindowProperty.cpp	View	2 chunks	+28 lines, -7 lines	0 comments	Download
M	trunk/Source/core/frame/LocalDOMWindow.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/Source/core/frame/LocalDOMWindow.cpp	View	2 chunks	+17 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Message was sent while issue was closed.

lgtm, thanks.