Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 563963004: Make templated GrProgramTResource subclass of GrProgramResource (Closed)

Created:
6 years, 3 months ago by bsalomon
Modified:
6 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Make templated GrProgramTResource subclass of GrProgramResource Committed: https://skia.googlesource.com/skia/+/c49233410e7278f0b95b8b0d28a80105a2930a88

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -24 lines) Patch
M include/gpu/GrProgramResource.h View 4 chunks +29 lines, -11 lines 0 comments Download
M include/gpu/GrTextureAccess.h View 3 chunks +7 lines, -6 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrRODrawState.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrTextureAccess.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bsalomon
This removes some of the ugly casting when using GrProgramResource. I'm thinking that I want ...
6 years, 3 months ago (2014-09-15 19:21:36 UTC) #2
robertphillips
lgtm
6 years, 3 months ago (2014-09-15 20:02:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563963004/1
6 years, 3 months ago (2014-09-15 20:03:56 UTC) #5
commit-bot: I haz the power
Failed to apply patch for src/gpu/GrDrawState.h: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-09-15 20:03:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563963004/20001
6 years, 3 months ago (2014-09-16 20:48:10 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 20:54:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as c49233410e7278f0b95b8b0d28a80105a2930a88

Powered by Google App Engine
This is Rietveld 408576698