Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 563963003: GN: Forward icu_config from public header config since we expose icu (Closed)

Created:
6 years, 3 months ago by jamesr
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

GN: Forward icu_config from public header config since we expose icu public/web/WebSettings.h does: and uses some types from ICU in its definition. Thus, anything that depends on the blink public API and includes this header must have the icu include dirs on their include path. This forwards icu_config from the blink_headers target so dependents do not have to do this themselves (unless they are linking against ICU directly) R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M public/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jamesr
6 years, 3 months ago (2014-09-11 23:53:48 UTC) #1
brettw
lgtm
6 years, 3 months ago (2014-09-12 03:28:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563963003/1
6 years, 3 months ago (2014-09-12 04:15:08 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 04:47:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181876

Powered by Google App Engine
This is Rietveld 408576698