Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1806)

Unified Diff: cc/resources/picture.cc

Issue 563963002: cc: Remove opaque rect from cc::Picture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pictureopaque: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/picture.h ('k') | cc/resources/picture_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/picture.cc
diff --git a/cc/resources/picture.cc b/cc/resources/picture.cc
index 5be80b150271efa396716e3c114e610bb606eab1..d3ca2966599af9c29dd773d084a9fdbb44196246 100644
--- a/cc/resources/picture.cc
+++ b/cc/resources/picture.cc
@@ -122,9 +122,7 @@ scoped_refptr<Picture> Picture::CreateFromSkpValue(const base::Value* value) {
return NULL;
gfx::Rect layer_rect(skpicture->width(), skpicture->height());
- gfx::Rect opaque_rect(skpicture->width(), skpicture->height());
-
- return make_scoped_refptr(new Picture(skpicture, layer_rect, opaque_rect));
+ return make_scoped_refptr(new Picture(skpicture, layer_rect));
}
scoped_refptr<Picture> Picture::CreateFromValue(const base::Value* raw_value) {
@@ -149,37 +147,24 @@ scoped_refptr<Picture> Picture::CreateFromValue(const base::Value* raw_value) {
if (!MathUtil::FromValue(layer_rect_value, &layer_rect))
return NULL;
- const base::Value* opaque_rect_value = NULL;
- if (!value->Get("params.opaque_rect", &opaque_rect_value))
- return NULL;
-
- gfx::Rect opaque_rect;
- if (!MathUtil::FromValue(opaque_rect_value, &opaque_rect))
- return NULL;
-
// Read the picture. This creates an empty picture on failure.
SkPicture* skpicture = SkPicture::CreateFromStream(&stream, &DecodeBitmap);
if (skpicture == NULL)
return NULL;
- return make_scoped_refptr(new Picture(skpicture, layer_rect, opaque_rect));
+ return make_scoped_refptr(new Picture(skpicture, layer_rect));
}
-Picture::Picture(SkPicture* picture,
- const gfx::Rect& layer_rect,
- const gfx::Rect& opaque_rect) :
- layer_rect_(layer_rect),
- opaque_rect_(opaque_rect),
- picture_(skia::AdoptRef(picture)),
- cell_size_(layer_rect.size()) {
+Picture::Picture(SkPicture* picture, const gfx::Rect& layer_rect)
+ : layer_rect_(layer_rect),
+ picture_(skia::AdoptRef(picture)),
+ cell_size_(layer_rect.size()) {
}
Picture::Picture(const skia::RefPtr<SkPicture>& picture,
const gfx::Rect& layer_rect,
- const gfx::Rect& opaque_rect,
const PixelRefMap& pixel_refs) :
layer_rect_(layer_rect),
- opaque_rect_(opaque_rect),
picture_(picture),
pixel_refs_(pixel_refs),
cell_size_(layer_rect.size()) {
@@ -287,8 +272,6 @@ void Picture::Record(ContentLayerClient* painter,
playback_.reset(recording->releasePlayback());
}
- opaque_rect_ = gfx::ToEnclosedRect(opaque_layer_rect);
-
EmitTraceSnapshot();
}
@@ -417,7 +400,6 @@ scoped_ptr<base::Value> Picture::AsValue() const {
// Encode the picture as base64.
scoped_ptr<base::DictionaryValue> res(new base::DictionaryValue());
res->Set("params.layer_rect", MathUtil::AsValue(layer_rect_).release());
- res->Set("params.opaque_rect", MathUtil::AsValue(opaque_rect_).release());
size_t serialized_size = stream.bytesWritten();
scoped_ptr<char[]> serialized_picture(new char[serialized_size]);
« no previous file with comments | « cc/resources/picture.h ('k') | cc/resources/picture_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698