Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 563963002: cc: Remove opaque rect from cc::Picture. (Closed)

Created:
6 years, 3 months ago by danakj
Modified:
6 years, 3 months ago
Reviewers:
nduca, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org, piman, Stephen Chennney, f(malita)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Remove opaque rect from cc::Picture. We don't do anything with this rect so remove it. R=nduca@chromium.org, vmpstr BUG=413479 Committed: https://crrev.com/1799b72d3d350b253702d34dad3b04651a43b656 Cr-Commit-Position: refs/heads/master@{#294664}

Patch Set 1 #

Patch Set 2 : pictureopaque: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -36 lines) Patch
M cc/resources/picture.h View 3 chunks +1 line, -6 lines 0 comments Download
M cc/resources/picture.cc View 4 chunks +6 lines, -24 lines 0 comments Download
M cc/resources/picture_unittest.cc View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
danakj
6 years, 3 months ago (2014-09-11 23:31:16 UTC) #1
danakj
Oops unrelated ResourceProvider change.
6 years, 3 months ago (2014-09-12 00:53:12 UTC) #2
vmpstr
lgtm % nduca
6 years, 3 months ago (2014-09-12 15:48:15 UTC) #3
nduca
lgtm
6 years, 3 months ago (2014-09-12 17:44:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563963002/20001
6 years, 3 months ago (2014-09-12 20:21:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 7a37b7f164c667c4e062345aa790375ab613b3ad
6 years, 3 months ago (2014-09-12 21:31:13 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 21:35:56 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1799b72d3d350b253702d34dad3b04651a43b656
Cr-Commit-Position: refs/heads/master@{#294664}

Powered by Google App Engine
This is Rietveld 408576698