Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 563953003: GN rules for everything in //mojo (Closed)

Created:
6 years, 3 months ago by jamesr
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GN rules for everything in //mojo This adds GN rules for everything in mojo except for python bindings targets and the android packaging rules. The group //mojo builds all targets in the subdir, just like the gyp 'mojo' target. R=brettw@chromium.org TBR=acolwell@chromium.org for //media/build/BUILD.gn Committed: https://crrev.com/f97b80e7f55057c38a7cf8b7a90acf4ab750d2a6 Cr-Commit-Position: refs/heads/master@{#294788}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : fix android build #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1024 lines, -59 lines) Patch
M media/blink/BUILD.gn View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M mojo/apps/js/BUILD.gn View 1 2 3 2 chunks +21 lines, -0 lines 0 comments Download
M mojo/common/test/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download
A mojo/dbus/BUILD.gn View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M mojo/examples/BUILD.gn View 1 chunk +29 lines, -0 lines 0 comments Download
A mojo/examples/apptest/BUILD.gn View 1 chunk +60 lines, -0 lines 0 comments Download
A mojo/examples/aura_demo/BUILD.gn View 1 2 1 chunk +50 lines, -0 lines 0 comments Download
A mojo/examples/browser/BUILD.gn View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A + mojo/examples/compositor_app/BUILD.gn View 1 2 1 chunk +16 lines, -14 lines 0 comments Download
A mojo/examples/content_handler_demo/BUILD.gn View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A mojo/examples/dbus_echo/BUILD.gn View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
A + mojo/examples/demo_launcher/BUILD.gn View 1 2 1 chunk +17 lines, -13 lines 0 comments Download
A + mojo/examples/embedded_app/BUILD.gn View 1 2 1 chunk +14 lines, -13 lines 0 comments Download
A mojo/examples/keyboard/BUILD.gn View 1 2 1 chunk +55 lines, -0 lines 0 comments Download
A mojo/examples/media_viewer/BUILD.gn View 1 2 3 4 1 chunk +41 lines, -0 lines 0 comments Download
A + mojo/examples/nesting_app/BUILD.gn View 1 2 1 chunk +15 lines, -13 lines 0 comments Download
A mojo/examples/pepper_container_app/BUILD.gn View 1 2 1 chunk +103 lines, -0 lines 0 comments Download
A mojo/examples/png_viewer/BUILD.gn View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M mojo/examples/sample_app/BUILD.gn View 1 chunk +13 lines, -3 lines 0 comments Download
M mojo/examples/surfaces_app/BUILD.gn View 1 2 3 2 chunks +31 lines, -0 lines 0 comments Download
A mojo/examples/window_manager/BUILD.gn View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A mojo/examples/wm_flow/BUILD.gn View 1 2 1 chunk +99 lines, -0 lines 0 comments Download
M mojo/mojo.gyp View 1 6 chunks +5 lines, -2 lines 0 comments Download
M mojo/mojo_apps.gypi View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/mojo_base.gyp View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 31 chunks +31 lines, -0 lines 0 comments Download
M mojo/mojo_public_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo_services.gypi View 1 2 3 chunks +3 lines, -1 line 0 comments Download
M mojo/public/c/system/tests/BUILD.gn View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
M mojo/services/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A mojo/services/html_viewer/BUILD.gn View 1 2 3 1 chunk +68 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/webmediaplayer_factory.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/services/native_viewport/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A mojo/tools/BUILD.gn View 1 chunk +23 lines, -0 lines 0 comments Download
A mojo/views/BUILD.gn View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
jamesr
Quick, review while it's hot!
6 years, 3 months ago (2014-09-12 00:36:43 UTC) #1
brettw
lgtm https://codereview.chromium.org/563953003/diff/20001/mojo/examples/png_viewer/BUILD.gn File mojo/examples/png_viewer/BUILD.gn (right): https://codereview.chromium.org/563953003/diff/20001/mojo/examples/png_viewer/BUILD.gn#newcode25 mojo/examples/png_viewer/BUILD.gn:25: ] + mojo_system_for_shared_library FWIW I'm not a fan ...
6 years, 3 months ago (2014-09-12 21:40:08 UTC) #2
jamesr
On 2014/09/12 21:40:08, brettw wrote: > lgtm > > https://codereview.chromium.org/563953003/diff/20001/mojo/examples/png_viewer/BUILD.gn > File mojo/examples/png_viewer/BUILD.gn (right): > ...
6 years, 3 months ago (2014-09-12 21:41:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563953003/40001
6 years, 3 months ago (2014-09-15 00:52:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/15408)
6 years, 3 months ago (2014-09-15 01:17:16 UTC) #7
jamesr
TBR'ing acolwell@ for a change to //media/blink/BUILD.gn to match the gyp file (webmediaplayer_impl.cc should not ...
6 years, 3 months ago (2014-09-15 04:05:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563953003/60001
6 years, 3 months ago (2014-09-15 04:05:59 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/15422) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/10401)
6 years, 3 months ago (2014-09-15 04:09:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563953003/80001
6 years, 3 months ago (2014-09-15 05:57:26 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 3f6a1a030493699efb888f0a29724d44bb90eaf4
6 years, 3 months ago (2014-09-15 06:54:51 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 06:57:01 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f97b80e7f55057c38a7cf8b7a90acf4ab750d2a6
Cr-Commit-Position: refs/heads/master@{#294788}

Powered by Google App Engine
This is Rietveld 408576698