Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issue 563923005: ServiceWorker: SWProviderHost no longer have to retain SWVersions (Closed)

Created:
6 years, 3 months ago by nhiroki
Modified:
6 years, 3 months ago
Reviewers:
michaeln, horo
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: SWProviderHost no longer have to retain SWVersions This is a cleanup patch. ServiceWorkerProviderHost owns ServiceWorkerRegistration and the registration owns ServiceWorkerVersions, so the provider host doesn't need to hold them. BUG=n/a TEST=run_webkit_tests.py --debug http/tests/serviceworker/ Committed: https://crrev.com/9625999ae9ad6a144c04a120cbad1d4b195fb371 Cr-Commit-Position: refs/heads/master@{#294732}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -108 lines) Patch
M content/browser/service_worker/service_worker_provider_host.h View 3 chunks +6 lines, -11 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 4 chunks +1 line, -17 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host_unittest.cc View 2 chunks +0 lines, -80 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nhiroki
Ptal, thanks!
6 years, 3 months ago (2014-09-12 09:10:54 UTC) #3
michaeln
woohooo -108 + 7, lgtm
6 years, 3 months ago (2014-09-12 21:52:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563923005/20001
6 years, 3 months ago (2014-09-13 04:38:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001) as f8948a62c329086ddb3289b95b427d433ac25eec
6 years, 3 months ago (2014-09-13 05:16:49 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 05:19:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9625999ae9ad6a144c04a120cbad1d4b195fb371
Cr-Commit-Position: refs/heads/master@{#294732}

Powered by Google App Engine
This is Rietveld 408576698