chrome/common/extensions/features/chrome_channel_feature_filter.cc - Issue 563923004: Move most extension feature unit tests to extensions_unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/features/chrome_channel_feature_filter.cc

Issue 563923004: Move most extension feature unit tests to extensions_unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/_permission_features.json ('K') | « chrome/common/extensions/api/_permission_features.json ('k') | chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc » ('j') | chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/features/chrome_channel_feature_filter.cc

diff --git a/chrome/common/extensions/features/chrome_channel_feature_filter.cc b/chrome/common/extensions/features/chrome_channel_feature_filter.cc

index abbec90ff89209670130831f4a1693026a959bd1..cbdc0ed33326d68bd2eeef14c1935f6f58cd9f88 100644

--- a/chrome/common/extensions/features/chrome_channel_feature_filter.cc

+++ b/chrome/common/extensions/features/chrome_channel_feature_filter.cc

@@ -5,6 +5,7 @@

#include "chrome/common/extensions/features/chrome_channel_feature_filter.h"

#include <map>

+#include <string>

#include "base/lazy_instance.h"

#include "base/strings/stringprintf.h"

@@ -53,7 +54,10 @@ chrome::VersionInfo::Channel GetChannelValue(const std::string& name) {

} // namespace

ChromeChannelFeatureFilter::ChromeChannelFeatureFilter(SimpleFeature* feature)

- : SimpleFeatureFilter(feature), channel_has_been_set_(false) {}

+ : SimpleFeatureFilter(feature),

+ channel_has_been_set_(false),

+ channel_(chrome::VersionInfo::CHANNEL_UNKNOWN) {

James Cook 2014/09/11 23:32:31 My editor found an uninitialized variable -- not t

ChromeChannelFeatureFilter::~ChromeChannelFeatureFilter() {}