Move most extension feature unit tests to extensions_unittests

Move most extension feature unit tests to extensions_unittests

They don't need to run in Chrome's unit_tests suite any more.

The tests that depend on Chrome's version channel information move to
ChromeChannelFeatureFilterTest.

BUG=413319, 397165
TEST=unit_tests ChromeChannelFeatureFilterTest.* and extensions_unittests

Committed: https://crrev.com/2a8b7f14f048318bfb1ce641a920d5c14e9842ba
Cr-Commit-Position: refs/heads/master@{#294627}

[James Cook, 2014-09-11 23:32:30]

jamescook@chromium.org changed reviewers:
+ rockot@chromium.org

[James Cook, 2014-09-11 23:32:31]

rockot, PTAL

Surely this code review is more fun than GoB.

https://codereview.chromium.org/563923004/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/_manifest_features.json (left):

https://codereview.chromium.org/563923004/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/_manifest_features.json:122: "description": {
Handled by the core manifest parser in src/extensions, so doesn't belong here.

https://codereview.chromium.org/563923004/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/_permission_features.json (left):

https://codereview.chromium.org/563923004/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/_permission_features.json:116: "bluetoothPrivate":
{
Bluetooth moved to src/extensions a few weeks ago, this got left behind.

https://codereview.chromium.org/563923004/diff/1/chrome/common/extensions/fea...
File chrome/common/extensions/features/chrome_channel_feature_filter.cc (right):

https://codereview.chromium.org/563923004/diff/1/chrome/common/extensions/fea...
chrome/common/extensions/features/chrome_channel_feature_filter.cc:59:
channel_(chrome::VersionInfo::CHANNEL_UNKNOWN) {
My editor found an uninitialized variable -- not that it matters in this case.

https://codereview.chromium.org/563923004/diff/1/chrome/common/extensions/fea...
File chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc
(right):

https://codereview.chromium.org/563923004/diff/1/chrome/common/extensions/fea...
chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc:1:
// Copyright 2014 The Chromium Authors. All rights reserved.
All the tests in this file are moved unchanged from simple_feature_unittest.cc
and complex_feature_unittest.cc.

https://codereview.chromium.org/563923004/diff/1/extensions/common/features/b...
File extensions/common/features/base_feature_provider_unittest.cc (right):

https://codereview.chromium.org/563923004/diff/1/extensions/common/features/b...
extensions/common/features/base_feature_provider_unittest.cc:40:
TEST(BaseFeatureProviderTest, ManifestFeatureAvailability) {
The important changes here are switching to description, app.background and
background as the features and switching from SimpleFeature* to Feature* so I
can test complex features.

https://codereview.chromium.org/563923004/diff/1/extensions/common/features/b...
extensions/common/features/base_feature_provider_unittest.cc:93:
TEST(BaseFeatureProviderTest, PermissionFeatureAvailability) {
Same thing here:
* SimpleFeature -> Feature
* contextMenus -> power
* chromePrivate -> bluetoothPrivate
* clipboardWrite -> serial

[Ken Rockot(use gerrit already), 2014-09-12 17:02:18]

Thanks for the comments. LGTM!

[James Cook, 2014-09-12 17:03:21]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-09-12 17:04:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/563923004/20001

[commit-bot: I haz the power, 2014-09-12 19:18:38]

Committed patchset #2 (id:20001) as bb20be8958fa41e5a617429862710a5b8758e76f

[commit-bot: I haz the power, 2014-09-12 19:23:28]

Patchset 2 (id:??) landed as
https://crrev.com/2a8b7f14f048318bfb1ce641a920d5c14e9842ba
Cr-Commit-Position: refs/heads/master@{#294627}