Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 563913002: Enable futex tests on Android. (Closed)

Created:
6 years, 3 months ago by jln (very slow on Chromium)
Modified:
6 years, 3 months ago
Reviewers:
mdempsky
CC:
chromium-reviews, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable futex tests on Android. Also fix the type of death messages expected in these tests. BUG=398611 Committed: https://crrev.com/b53755f4a85f9564400d8835ef0a7a0ada56b67f Cr-Commit-Position: refs/heads/master@{#294497}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M sandbox/linux/services/android_futex.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jln (very slow on Chromium)
Matthew: PTAL!
6 years, 3 months ago (2014-09-11 21:17:16 UTC) #2
mdempsky
LGTM
6 years, 3 months ago (2014-09-11 21:30:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563913002/20001
6 years, 3 months ago (2014-09-11 22:24:00 UTC) #5
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-09-12 00:05:19 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 00:22:18 UTC) #8
Patchset 3 (id:??) landed as
https://crrev.com/b53755f4a85f9564400d8835ef0a7a0ada56b67f
Cr-Commit-Position: refs/heads/master@{#294497}

Powered by Google App Engine
This is Rietveld 408576698