Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 563893002: Revert of Revert of Split out CSSParser public API (Closed)

Created:
6 years, 3 months ago by jianli
Modified:
6 years, 3 months ago
CC:
blink-reviews, shans, eae+blinkwatch, fs, yurys+blink_chromium.org, apavlov+blink_chromium.org, loislo+blink_chromium.org, Steve Block, rune+blink, krit, Yoav Weiss, aandrey+blink_chromium.org, arv+blink, blink-reviews-dom_chromium.org, malch+blink_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, Timothy Loh, abarth-chromium, dstockwell, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, pdr., rwlbuis, Eric Willigers, kenneth.christiansen, rjwright, sof, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, gyuyoung.kim_webkit.org, darktears, Stephen Chennney, blink-reviews-animation_chromium.org, kouhei+svg_chromium.org, vsevik+blink_chromium.org, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), sergeyv+blink_chromium.org, ojan
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Revert of Split out CSSParser public API (patchset #1 id:1 of https://codereview.chromium.org/566703002/) Reason for revert: Bring it back since the OilPan builder is not a tree closer. Original issue's description: > Revert of Split out CSSParser public API (patchset #3 id:40001 of https://codereview.chromium.org/566483002/) > > Reason for revert: > Caused compiling errors. > > Original issue's description: > > Split out CSSParser public API > > > > This patch separates the public API of BisonCSSParser from the hundreds > > of public methods it exposes. The plan is to build a new parser based on > > the css-syntax specification, which will eventually complete replace the > > bison-based parser. The functions in this class will do the run-time > > switching between the bison parser and the new (unwritten) parser. > > > > For the functions here which are only ever used with a newly instantiated > > BisonCSSParser, I've moved instantiation to inside the CSSParser so that > > the functions can be static. > > > > This is an updated version of a patch by eseidel from 8 months ago: > > https://codereview.chromium.org/112933010/ > > > > BUG=330389 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181825 > > TBR=eseidel@chromium.org,esprehn@chromium.org,alancutter@chromium.org,timloh@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=330389 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181837 TBR=eseidel@chromium.org,esprehn@chromium.org,alancutter@chromium.org,timloh@chromium.org NOTREECHECKS=true NOTRY=true BUG=330389 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -91 lines) Patch
M Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationHelpers.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/DeferredLegacyStyleInterpolationTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/EffectInput.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/TimingInput.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/css/CSSGroupingRule.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/css/CSSKeyframeRule.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSKeyframesRule.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/css/CSSMatrix.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSPageRule.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSStyleRule.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSStyleSheet.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/css/CSSValueList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValuePool.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/DOMWindowCSS.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M Source/core/css/FontFace.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/css/FontFaceSet.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/MediaList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySet.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/StyleSheet.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
A Source/core/css/parser/CSSParser.h View 1 chunk +52 lines, -0 lines 0 comments Download
A Source/core/css/parser/CSSParser.cpp View 1 chunk +94 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/CSSSelectorWatch.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Element.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/SelectorQuery.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/html/HTMLBodyElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLContentElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasStyle.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 8 chunks +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGAnimateElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedTypeAnimator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSelector.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jianli
Created Revert of Revert of Split out CSSParser public API
6 years, 3 months ago (2014-09-11 20:41:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563893002/1
6 years, 3 months ago (2014-09-11 20:42:35 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 20:43:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181849

Powered by Google App Engine
This is Rietveld 408576698