DescriptionRevert of Revert of CSP: Convert CSPSource constructor bools into a enum. (patchset #1 id:1 of https://codereview.chromium.org/565723002/)
Reason for revert:
Not a culprit.
Original issue's description:
> Revert of CSP: Convert CSPSource constructor bools into a enum. (patchset #1 id:1 of https://codereview.chromium.org/568433002/)
>
> Reason for revert:
> Your patch broke quite a number of webkit tests:
> http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8%20%28retina%29/builds/19050
> http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/31462
>
> Original issue's description:
> > CSP: Convert CSPSource constructor bools into a enum.
> >
> > Rather than passing the wildcard disposition of CSPSource's hosts and ports
> > as booleans, we should have an enum that allows us to figure out hat we
> > mean at the callsite. This patch adds CSPSource::WildcardDisposition in
> > order to make this clear.
> >
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181821
>
> TBR=jochen@chromium.org,mkwst@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181833
TBR=jochen@chromium.org,mkwst@chromium.org
NOTREECHECKS=true
NOTRY=true
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181838
Patch Set 1 #
Created: 6 years, 3 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|