Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 563853003: Cleanup V8 histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 4ae331febdb5cb239bd25b8379a86775b255f695..88b359acd0a613b6103631b98fa6802f366356d7 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -35720,16 +35720,25 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="V8.ASTOptimization">
+ <obsolete>
+ This histogram is no longer present in V8
+ </obsolete>
<owner>jochen@chromium.org</owner>
<summary>TBD</summary>
</histogram>
<histogram name="V8.CodeCreation">
+ <obsolete>
+ This histogram is no longer present in V8
+ </obsolete>
<owner>jochen@chromium.org</owner>
<summary>TBD</summary>
</histogram>
<histogram name="V8.CodeGeneration">
+ <obsolete>
+ This histogram is no longer present in V8
+ </obsolete>
<owner>jochen@chromium.org</owner>
<summary>Time spent generating native code for functions.</summary>
</histogram>
@@ -35743,62 +35752,89 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
-<histogram name="V8.Compile">
+<histogram name="V8.Compile" units="milliseconds">
<owner>jochen@chromium.org</owner>
- <summary>Time spent in V8 compiler.</summary>
+ <owner>yangguo@chromium.org</owner>
+ <summary>Time spent in V8 compiler (full codegen).</summary>
</histogram>
-<histogram name="V8.CompileEval">
+<histogram name="V8.CompileEval" units="milliseconds">
<owner>jochen@chromium.org</owner>
- <summary>Time spent in V8 compiler for eval.</summary>
+ <owner>yangguo@chromium.org</owner>
+ <summary>Time spent in V8 compiler (full codegen) for eval.</summary>
</histogram>
<histogram name="V8.CompileLazy">
+ <obsolete>
+ This histogram is no longer present in V8
+ </obsolete>
<owner>jochen@chromium.org</owner>
<summary>Time spent compiling functions lazily on first run.</summary>
</histogram>
<histogram name="V8.DeferredCodeGeneration">
+ <obsolete>
+ This histogram is no longer present in V8
+ </obsolete>
<owner>jochen@chromium.org</owner>
<summary>Time spent generating deferred code stubs.</summary>
</histogram>
<histogram name="V8.ExecutableMemoryMax" units="bytes">
+ <obsolete>
+ This histogram is no longer present in V8
+ </obsolete>
<owner>jochen@chromium.org</owner>
<summary>
The maximum memory used to store V8 compiled code on a given process.
</summary>
</histogram>
-<histogram name="V8.GCCompactor">
+<histogram name="V8.GCCompactor" units="milliseconds">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
<summary>Time spent in mark-sweep phase of GC.</summary>
</histogram>
-<histogram name="V8.GCContext">
+<histogram name="V8.GCContext" units="milliseconds">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
- <summary>
- Time spent GC'ing on context creation to get rid of older contexts.
- </summary>
+ <owner>hpayer@chromium.org</owner>
+ <summary>Time spent doing a full GC during an IdleNotification.</summary>
</histogram>
-<histogram name="V8.GCScavenger">
+<histogram name="V8.GCIdleNotification" units="milliseconds">
+ <owner>jochen@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
+ <summary>Time spent in IdleNotifications.</summary>
+</histogram>
+
+<histogram name="V8.GCIdleTimeAllottedInMS" units="milliseconds">
+ <owner>jochen@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
+ <summary>Idle time passed to V8 via IdleNotifications.</summary>
+</histogram>
+
+<histogram name="V8.GCIncrementalMarking" units="milliseconds">
+ <owner>jochen@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
+ <summary>Time spent doing incremental marking steps during GC.</summary>
+</histogram>
+
+<histogram name="V8.GCLowMemoryNotification" units="milliseconds">
+ <owner>jochen@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
+ <summary>Time spent in LowMemoryNotifications.</summary>
+</histogram>
+
+<histogram name="V8.GCScavenger" units="milliseconds">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
<summary>Time spent in scavenging phase of GC.</summary>
</histogram>
<histogram name="V8.MemoryExternalFragmentationCellSpace" units="percent">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
External memory fragmentation in the cell space after each GC in percent.
</summary>
@@ -35806,8 +35842,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryExternalFragmentationCodeSpace" units="percent">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
External memory fragmentation in the code space after each GC in percent.
</summary>
@@ -35815,8 +35850,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryExternalFragmentationLoSpace" units="percent">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
External memory fragmentation in the large object space after each GC in
percent.
@@ -35825,8 +35859,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryExternalFragmentationMapSpace" units="percent">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
External memory fragmentation in the map space after each GC in percent.
</summary>
@@ -35834,8 +35867,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryExternalFragmentationOldDataSpace" units="percent">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
External memory fragmentation in the old data space after each GC in
percent.
@@ -35844,8 +35876,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryExternalFragmentationOldPointerSpace" units="percent">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
External memory fragmentation in the old pointer space after each GC in
percent.
@@ -35854,8 +35885,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryExternalFragmentationTotal" units="percent">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
Total external memory fragmentation after each GC in percent.
</summary>
@@ -35863,9 +35893,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapFractionCellSpace" units="percent">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
- <owner>rmcilroy@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
Fraction of the total heap used by the cell space after each GC in percent.
</summary>
@@ -35873,9 +35901,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapFractionCodeSpace" units="percent">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
- <owner>rmcilroy@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
Fraction of the total heap used by the code space after each GC in percent.
</summary>
@@ -35883,9 +35909,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapFractionLoSpace" units="percent">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
- <owner>rmcilroy@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
Fraction of the total heap used by the lo space after each GC in percent.
</summary>
@@ -35893,9 +35917,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapFractionMapSpace" units="percent">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
- <owner>rmcilroy@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
Fraction of the total heap used by the map space after each GC in percent.
</summary>
@@ -35903,9 +35925,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapFractionNewSpace" units="percent">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
- <owner>rmcilroy@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
Fraction of the total heap used by the new space after each GC in percent.
</summary>
@@ -35913,9 +35933,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapFractionOldDataSpace" units="percent">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
- <owner>rmcilroy@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
Fraction of the total heap used by the old data space after each GC in
percent.
@@ -35924,9 +35942,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapFractionOldPointerSpace" units="percent">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
- <owner>rmcilroy@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
Fraction of the total heap used by the old pointer space after each GC in
percent.
@@ -35935,8 +35951,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapSampleCellSpaceCommitted" units="KB">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
The size of committed memory in the cell space after each GC in KB.
</summary>
@@ -35944,8 +35959,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapSampleCodeSpaceCommitted" units="KB">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
The size of committed memory in the code space after each GC in KB.
</summary>
@@ -35953,8 +35967,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapSampleMapSpaceCommitted" units="KB">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
The size of committed memory in the map space after each GC in KB.
</summary>
@@ -35962,9 +35975,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapSampleTotalCommitted" units="KB">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
- <owner>rmcilroy@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
The total size of committed memory used by V8 after each GC in KB.
</summary>
@@ -35972,57 +35983,76 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapSampleTotalUsed" units="KB">
<owner>jochen@chromium.org</owner>
- <owner>hajimehoshi@chromium.org</owner>
- <owner>kouhei@chromium.org</owner>
- <owner>rmcilroy@chromium.org</owner>
+ <owner>hpayer@chromium.org</owner>
<summary>
The total size of live memory used by V8 after each GC in KB.
</summary>
</histogram>
-<histogram name="V8.Parse">
+<histogram name="V8.Parse" units="milliseconds">
<owner>jochen@chromium.org</owner>
+ <owner>marja@chromium.org</owner>
<summary>Time spent in V8 parser.</summary>
</histogram>
-<histogram name="V8.ParseLazy">
+<histogram name="V8.ParseLazy" units="milliseconds">
<owner>jochen@chromium.org</owner>
+ <owner>marja@chromium.org</owner>
<summary>
Time spent parsing functions when they are lazily compiled on first run.
</summary>
</histogram>
-<histogram name="V8.PreParse">
+<histogram name="V8.PreParse" units="milliseconds">
<owner>jochen@chromium.org</owner>
+ <owner>marja@chromium.org</owner>
<summary>Time spent preparsing source code.</summary>
</histogram>
<histogram name="V8.Rewriting">
+ <obsolete>
+ This histogram is no longer present in V8
+ </obsolete>
<owner>jochen@chromium.org</owner>
<summary>Time spent on rewriting ASTs before compilation.</summary>
</histogram>
<histogram name="V8.RSetLO">
+ <obsolete>
+ This histogram is no longer present in V8
+ </obsolete>
<owner>jochen@chromium.org</owner>
<summary>TBD</summary>
</histogram>
<histogram name="V8.RSetPaged">
+ <obsolete>
+ This histogram is no longer present in V8
+ </obsolete>
<owner>jochen@chromium.org</owner>
<summary>TBD</summary>
</histogram>
<histogram name="V8.ScriptCache">
<owner>jochen@chromium.org</owner>
- <summary>TBD</summary>
+ <owner>yangguo@chromium.org</owner>
+ <summary>
+ The generation a compiled script was found in the compilation cache.
+ </summary>
</histogram>
<histogram name="V8.UsageAnalysis">
+ <obsolete>
+ This histogram is no longer present in V8
+ </obsolete>
<owner>jochen@chromium.org</owner>
<summary>Time spent analysing the usage of variables.</summary>
</histogram>
<histogram name="V8.VariableAllocation">
+ <obsolete>
+ This histogram is no longer present in V8
+ </obsolete>
<owner>jochen@chromium.org</owner>
<summary>TBD</summary>
</histogram>
@@ -55333,7 +55363,7 @@ To add a new entry, add it with any value and run test to compute valid value.
</histogram_suffixes>
<histogram_suffixes name="V8SpecialApps" separator=".">
- <suffix name="docs" label="Custom histogram for Google Docs"/>
+ <suffix name="docs" label="Custom histogram for Google Docs and Drive"/>
<suffix name="gmail" label="Custom histogram for GMail"/>
<suffix name="plus" label="Custom histogram for Google+"/>
<affected-histogram name="V8.MemoryExternalFragmentationTotal"/>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698