Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 563853002: Speculative fix for MaxTouchPoints returning incorrect value on Windows. (Closed)

Created:
6 years, 3 months ago by bokan
Modified:
6 years, 3 months ago
Reviewers:
girard, sadrul
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Speculative fix for MaxTouchPoints returning incorrect value on Windows. Windows 7 appears to sometimes return an incorrect value for max touch points, returning 1 when there's in fact no touch devices present. This breaks some web pages that use a non-zero number of touch points as a signal that the devices has a touch screen. As this is specific to certain Win7 configurations, I don't have a repro; however, reports in the bug show that the SM_DIGITIZER setting does indeed return the correct status of "no touchscreen". In light of this, we speculatively return 0 touches if there's no touchscreen device present. BUG=352942 Committed: https://crrev.com/c7c9e396975f37ef865bf4cea63ac64d93295a3d Cr-Commit-Position: refs/heads/master@{#294467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/base/touch/touch_device_win.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
bokan
Sadrul, PTAL. Thanks.
6 years, 3 months ago (2014-09-11 18:36:13 UTC) #1
bokan
Actually adding sadrul@...
6 years, 3 months ago (2014-09-11 18:36:44 UTC) #3
sadrul
/cc +girard@ lgtm
6 years, 3 months ago (2014-09-11 19:33:37 UTC) #4
girard
On 2014/09/11 19:33:37, sadrul wrote: > /cc +girard@ > > lgtm lgtm
6 years, 3 months ago (2014-09-11 19:51:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563853002/1
6 years, 3 months ago (2014-09-11 19:55:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as b74e6fccfb025037d6b419a592cdd494ce4c4a67
6 years, 3 months ago (2014-09-11 21:18:09 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 21:40:52 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7c9e396975f37ef865bf4cea63ac64d93295a3d
Cr-Commit-Position: refs/heads/master@{#294467}

Powered by Google App Engine
This is Rietveld 408576698