Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 56383002: Disable enterprise user reporting by default in M32. (Closed)

Created:
7 years, 1 month ago by Steve Condie
Modified:
7 years, 1 month ago
Reviewers:
Joao da Silva
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Disable enterprise user reporting by default in M32. BUG=308664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232896

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M chrome/browser/chromeos/policy/device_status_collector.cc View 1 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector_browsertest.cc View 1 3 chunks +5 lines, -0 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Steve Condie
User reporting no-go'ed for M32; adding a flag to disable by default.
7 years, 1 month ago (2013-11-01 18:35:06 UTC) #1
Joao da Silva
lgtm after moving the flag to the new file. https://codereview.chromium.org/56383002/diff/1/chrome/common/chrome_switches.h File chrome/common/chrome_switches.h (right): https://codereview.chromium.org/56383002/diff/1/chrome/common/chrome_switches.h#newcode179 chrome/common/chrome_switches.h:179: ...
7 years, 1 month ago (2013-11-03 09:21:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stepco@chromium.org/56383002/110001
7 years, 1 month ago (2013-11-04 18:59:48 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=218752
7 years, 1 month ago (2013-11-04 22:44:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stepco@chromium.org/56383002/110001
7 years, 1 month ago (2013-11-04 23:47:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stepco@chromium.org/56383002/110001
7 years, 1 month ago (2013-11-05 00:25:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stepco@chromium.org/56383002/110001
7 years, 1 month ago (2013-11-05 03:20:32 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 04:01:47 UTC) #8
Message was sent while issue was closed. 
Change committed as 232896

Powered by Google App Engine
This is Rietveld 408576698