Migrate walker tests from upstream ChromeVox.

Migrate walker tests from upstream ChromeVox.

BUG=371692
Committed: https://crrev.com/eb1298425d480f99ca4f0309972686b458486e6a
Cr-Commit-Position: refs/heads/master@{#295077}

[Peter Lundblad, 2014-09-12 15:38:03]

plundblad@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[Peter Lundblad, 2014-09-12 15:38:04]

These are pretty straight-forward...

[dmazzoni, 2014-09-12 15:53:27]

lgtm with nits

thanks!

https://codereview.chromium.org/563773003/diff/40001/chrome/browser/resources...
File
chrome/browser/resources/chromeos/chromevox/walkers/character_walker_test.unitjs
(right):

https://codereview.chromium.org/563773003/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/walkers/character_walker_test.unitjs:92:
* @override
nit: did you mean to have @override here?

https://codereview.chromium.org/563773003/diff/40001/chrome/browser/resources...
File
chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker_test.unitjs
(right):

https://codereview.chromium.org/563773003/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker_test.unitjs:46:
this.a = cvox.CursorSelection.fromNode(document.getElementById('a'));
nit: we're using $('a') in the other tests, since the presubmit script required
it for webui tests. i think that isn't catching it anymore because we renamed
the file extension.

want to do that here, or switch the others back go document.getElementById?

https://codereview.chromium.org/563773003/diff/40001/chrome/browser/resources...
File
chrome/browser/resources/chromeos/chromevox/walkers/math_shifter_test.unitjs
(right):

https://codereview.chromium.org/563773003/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/walkers/math_shifter_test.unitjs:51:
console.log('Starting');
Let's delete console logging if not necessary

[Peter Lundblad, 2014-09-12 16:04:39]

The CQ bit was checked by plundblad@chromium.org

[commit-bot: I haz the power, 2014-09-12 16:05:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/563773003/60001

[Peter Lundblad, 2014-09-12 16:09:37]

Thanks for amazing response time as always!

dmazzoni@chromium.org writes:
> lgtm with nits
> 
> thanks!
> 
> 
> 
>
https://codereview.chromium.org/563773003/diff/40001/chrome/browser/resources...
> File
>
chrome/browser/resources/chromeos/chromevox/walkers/character_walker_test.unitjs
> (right):
> 
>
https://codereview.chromium.org/563773003/diff/40001/chrome/browser/resources...
>
chrome/browser/resources/chromeos/chromevox/walkers/character_walker_test.unitjs:92:
> * @override
> nit: did you mean to have @override here?

Nope, removed.

>
https://codereview.chromium.org/563773003/diff/40001/chrome/browser/resources...
> File
>
chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker_test.unitjs
> (right):
> 
>
https://codereview.chromium.org/563773003/diff/40001/chrome/browser/resources...
>
chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker_test.unitjs:46:
> this.a = cvox.CursorSelection.fromNode(document.getElementById('a'));
> nit: we're using $('a') in the other tests, since the presubmit script
> required it for webui tests. i think that isn't catching it anymore
> because we renamed the file extension.

Right, and these tests were done manually (not with your script) because they
had some weirdnesses, so I knew there'd be one file I'd missed;)
Fixed all 4.

> want to do that here, or switch the others back go
> document.getElementById?

Chromium js style is $(), so I went with that.

>
https://codereview.chromium.org/563773003/diff/40001/chrome/browser/resources...
> File
> chrome/browser/resources/chromeos/chromevox/walkers/math_shifter_test.unitjs
> (right):
> 
>
https://codereview.chromium.org/563773003/diff/40001/chrome/browser/resources...
>
chrome/browser/resources/chromeos/chromevox/walkers/math_shifter_test.unitjs:51:
> console.log('Starting');
> Let's delete console logging if not necessary

Yeah, done.


Thanks,
//Peter

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-09-12 17:14:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 17:14:36]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peter Lundblad, 2014-09-16 15:09:32]

The CQ bit was checked by plundblad@chromium.org

[commit-bot: I haz the power, 2014-09-16 15:10:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/563773003/140001

[commit-bot: I haz the power, 2014-09-16 16:09:09]

Committed patchset #8 (id:140001) as 3891a54f659dcbae91c56c98a9e2f10ab325224b

[commit-bot: I haz the power, 2014-09-16 16:10:32]

Patchset 8 (id:??) landed as
https://crrev.com/eb1298425d480f99ca4f0309972686b458486e6a
Cr-Commit-Position: refs/heads/master@{#295077}