Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 563773002: Allow setting different memory limits for different stream types (Closed)

Created:
6 years, 3 months ago by Henrik Steen
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow setting different memory limits for different stream types BUG=413214 R=acolwell@chromium.org Committed: https://crrev.com/1ab35435728e7ff22226adc6ee6f7cebdd9c46f2 Cr-Commit-Position: refs/heads/master@{#294427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -24 lines) Patch
M media/filters/chunk_demuxer.h View 2 chunks +6 lines, -5 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 3 chunks +26 lines, -15 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 2 chunks +43 lines, -2 lines 0 comments Download
M media/filters/source_buffer_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/source_buffer_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Henrik Steen
Hi, Aaron. Here's a review for the patch we discussed last week.
6 years, 3 months ago (2014-09-11 12:49:37 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 3 months ago (2014-09-11 17:08:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563773002/1
6 years, 3 months ago (2014-09-11 17:13:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3bc337f8e19e003626a4efccfcfe5aaf388ce6dc
6 years, 3 months ago (2014-09-11 18:32:58 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 19:09:05 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ab35435728e7ff22226adc6ee6f7cebdd9c46f2
Cr-Commit-Position: refs/heads/master@{#294427}

Powered by Google App Engine
This is Rietveld 408576698