Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 563763004: Add ObjectProxy::CallMethodAndBlockWithErrorDetails methods (Closed)

Created:
6 years, 3 months ago by Alex Vakulenko
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add ObjectProxy::CallMethodAndBlockWithErrorDetails methods Currently, ObjectProxy::CallMethodAndBlock() returns NULL on failure but the D-Bus error details are not passed to the caller. Added a method that would return the D-Bus error information to the caller and switched ObjectProxy::CallMethodAndBlock() to use the new method instead. BUG=chromium:414838 TEST=Build Chrome TEST=ninja -C out/Debug dbus_unittests && out/Debug/dbus_unittests Committed: https://crrev.com/6b571de0807eea51c863cf0aa18403ae6c18ba65 Cr-Commit-Position: refs/heads/master@{#295212}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -11 lines) Patch
M dbus/mock_object_proxy.h View 1 chunk +11 lines, -0 lines 0 comments Download
M dbus/mock_unittest.cc View 5 chunks +35 lines, -2 lines 0 comments Download
M dbus/object_proxy.h View 1 3 chunks +13 lines, -2 lines 0 comments Download
M dbus/object_proxy.cc View 4 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Alex Vakulenko (Google)
6 years, 3 months ago (2014-09-16 22:21:24 UTC) #3
keybuk
lgtm after nit fix https://codereview.chromium.org/563763004/diff/1/dbus/object_proxy.h File dbus/object_proxy.h (right): https://codereview.chromium.org/563763004/diff/1/dbus/object_proxy.h#newcode29 dbus/object_proxy.h:29: class ScopedDBusError; nit: alphabetical order ...
6 years, 3 months ago (2014-09-16 22:35:01 UTC) #4
Alex Vakulenko (Google)
https://codereview.chromium.org/563763004/diff/1/dbus/object_proxy.h File dbus/object_proxy.h (right): https://codereview.chromium.org/563763004/diff/1/dbus/object_proxy.h#newcode29 dbus/object_proxy.h:29: class ScopedDBusError; On 2014/09/16 22:35:01, keybuk wrote: > nit: ...
6 years, 3 months ago (2014-09-16 22:42:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563763004/20001
6 years, 3 months ago (2014-09-16 22:45:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 9386eebfc1021eadd8121d24a64e66489f1026dc
6 years, 3 months ago (2014-09-17 01:44:17 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 01:45:34 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b571de0807eea51c863cf0aa18403ae6c18ba65
Cr-Commit-Position: refs/heads/master@{#295212}

Powered by Google App Engine
This is Rietveld 408576698