Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 563743004: Revert of Files.app: Split background.js (Closed)

Created:
6 years, 3 months ago by yoshiki
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Files.app: Split background.js (patchset #4 id:60001 of https://codereview.chromium.org/562103002/) Reason for revert: This patch breaks the test. Original issue's description: > Files.app: Split background.js > > This patch splits the background.js into the 3 files (background_base.js, app_window_wrapper.js, background.js), extracting the common classes. > > This patch itself doesn't change any functionality, but the extracted files will be used in the separated audio player app in near future. > > BUG=375039 > TEST=browser_test passes > > Committed: https://crrev.com/479878c12c436c0bec667483df29fe1f23b710a2 > Cr-Commit-Position: refs/heads/master@{#294998} TBR=hirono@chromium.org NOTREECHECKS=true NOTRY=true BUG=375039 Committed: https://crrev.com/326fdba9410033d6d49d4d36ee44818e6a6e8a80 Cr-Commit-Position: refs/heads/master@{#295019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+400 lines, -435 lines) Patch
D ui/file_manager/file_manager/background/js/app_window_wrapper.js View 1 chunk +0 lines, -346 lines 0 comments Download
M ui/file_manager/file_manager/background/js/background.js View 12 chunks +382 lines, -30 lines 0 comments Download
D ui/file_manager/file_manager/background/js/background_base.js View 1 chunk +0 lines, -47 lines 0 comments Download
M ui/file_manager/file_manager/manifest.json View 3 chunks +14 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
yoshiki
Created Revert of Files.app: Split background.js
6 years, 3 months ago (2014-09-16 06:23:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563743004/1
6 years, 3 months ago (2014-09-16 06:23:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 547da497a4fc771e9f4888653ab27ee9f65bf80e
6 years, 3 months ago (2014-09-16 06:24:48 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 06:26:05 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/326fdba9410033d6d49d4d36ee44818e6a6e8a80
Cr-Commit-Position: refs/heads/master@{#295019}

Powered by Google App Engine
This is Rietveld 408576698