Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 563723006: Fix one more edge case with WebMediaPlayerDelegate notifications. (Closed)

Created:
6 years, 3 months ago by DaleCurtis
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@psb
Project:
chromium
Visibility:
Public.

Description

Fix one more edge case with WebMediaPlayerDelegate notifications. Missed this one when testing earlier. BUG=43667, 367785 TEST=DCHECKs no longer fire. Committed: https://crrev.com/bb761e12a71a47ffcde561f003fa30bec5cac570 Cr-Commit-Position: refs/heads/master@{#294517}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/blink/webmediaplayer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
DaleCurtis
One more :|
6 years, 3 months ago (2014-09-11 21:50:38 UTC) #2
acolwell GONE FROM CHROMIUM
lgtm
6 years, 3 months ago (2014-09-11 21:55:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563723006/1
6 years, 3 months ago (2014-09-11 22:24:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 423fc28cc7a0d4a40652d4204d1d115eff80d746
6 years, 3 months ago (2014-09-12 01:17:23 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 01:19:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb761e12a71a47ffcde561f003fa30bec5cac570
Cr-Commit-Position: refs/heads/master@{#294517}

Powered by Google App Engine
This is Rietveld 408576698