Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: src/objects.cc

Issue 563723002: Expect requiring access check on objects with hidden properties. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 31fa7e4e61d13977ad0bf87ed407dbcaef22cfa4..4459a5b05cafabe7e0dae338d501e358e3ffedf2 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -4714,12 +4714,8 @@ Object* JSObject::GetHiddenPropertiesHashTable() {
Isolate* isolate = GetIsolate();
LookupIterator it(handle(this), isolate->factory()->hidden_string(),
LookupIterator::OWN_SKIP_INTERCEPTOR);
- CHECK_NE(LookupIterator::ACCESS_CHECK, it.state());
- if (it.state() == LookupIterator::DATA) {
- return *it.GetDataValue();
- }
- DCHECK(!it.IsFound());
- return GetHeap()->undefined_value();
+ // Access check is always skipped for the hidden string anyways.
+ return *GetDataProperty(&it);
}
}
« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698