Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/objects.cc

Issue 563723002: Expect requiring access check on objects with hidden properties. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/allocation-site-scopes.h" 8 #include "src/allocation-site-scopes.h"
9 #include "src/api.h" 9 #include "src/api.h"
10 #include "src/arguments.h" 10 #include "src/arguments.h"
(...skipping 4696 matching lines...) Expand 10 before | Expand all | Expand 10 after
4707 } else { 4707 } else {
4708 return GetHeap()->undefined_value(); 4708 return GetHeap()->undefined_value();
4709 } 4709 }
4710 } else { 4710 } else {
4711 return GetHeap()->undefined_value(); 4711 return GetHeap()->undefined_value();
4712 } 4712 }
4713 } else { 4713 } else {
4714 Isolate* isolate = GetIsolate(); 4714 Isolate* isolate = GetIsolate();
4715 LookupIterator it(handle(this), isolate->factory()->hidden_string(), 4715 LookupIterator it(handle(this), isolate->factory()->hidden_string(),
4716 LookupIterator::OWN_SKIP_INTERCEPTOR); 4716 LookupIterator::OWN_SKIP_INTERCEPTOR);
4717 CHECK_NE(LookupIterator::ACCESS_CHECK, it.state()); 4717 // Access check is always skipped for the hidden string anyways.
4718 if (it.state() == LookupIterator::DATA) { 4718 return *GetDataProperty(&it);
4719 return *it.GetDataValue();
4720 }
4721 DCHECK(!it.IsFound());
4722 return GetHeap()->undefined_value();
4723 } 4719 }
4724 } 4720 }
4725 4721
4726 Handle<ObjectHashTable> JSObject::GetOrCreateHiddenPropertiesHashtable( 4722 Handle<ObjectHashTable> JSObject::GetOrCreateHiddenPropertiesHashtable(
4727 Handle<JSObject> object) { 4723 Handle<JSObject> object) {
4728 Isolate* isolate = object->GetIsolate(); 4724 Isolate* isolate = object->GetIsolate();
4729 4725
4730 static const int kInitialCapacity = 4; 4726 static const int kInitialCapacity = 4;
4731 Handle<Object> inline_value(object->GetHiddenPropertiesHashTable(), isolate); 4727 Handle<Object> inline_value(object->GetHiddenPropertiesHashTable(), isolate);
4732 if (inline_value->IsHashTable()) { 4728 if (inline_value->IsHashTable()) {
(...skipping 11669 matching lines...) Expand 10 before | Expand all | Expand 10 after
16402 #define ERROR_MESSAGES_TEXTS(C, T) T, 16398 #define ERROR_MESSAGES_TEXTS(C, T) T,
16403 static const char* error_messages_[] = { 16399 static const char* error_messages_[] = {
16404 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS) 16400 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)
16405 }; 16401 };
16406 #undef ERROR_MESSAGES_TEXTS 16402 #undef ERROR_MESSAGES_TEXTS
16407 return error_messages_[reason]; 16403 return error_messages_[reason];
16408 } 16404 }
16409 16405
16410 16406
16411 } } // namespace v8::internal 16407 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698