Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issue 563713003: Avoid DCHECK on 3x scaled screens. (Closed)

Created:
6 years, 3 months ago by lliabraa
Modified:
6 years, 3 months ago
CC:
chromium-reviews, justincohen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Avoid DCHECK on 3x scaled screens. As a temporary solution, use 2x assets on 3x screens. BUG=413300 Committed: https://crrev.com/e16fd72864e815f3e952c29acf99b1bf6d438e86 Cr-Commit-Position: refs/heads/master@{#294434}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ui/base/resource/resource_bundle.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
lliabraa
@rohitrao for iOS review.
6 years, 3 months ago (2014-09-11 17:19:24 UTC) #2
rohitrao (ping after 24h)
LGTM +tony for OWNERS We have not yet created 300P assets, which is why we've ...
6 years, 3 months ago (2014-09-11 17:26:28 UTC) #4
tony
LGTM
6 years, 3 months ago (2014-09-11 17:32:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563713003/1
6 years, 3 months ago (2014-09-11 17:40:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as e85117d8232d883ba3b4f6d60a76323d31479f5c
6 years, 3 months ago (2014-09-11 18:53:01 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 19:09:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e16fd72864e815f3e952c29acf99b1bf6d438e86
Cr-Commit-Position: refs/heads/master@{#294434}

Powered by Google App Engine
This is Rietveld 408576698