| Index: Source/modules/filesystem/FileSystemCallbacks.cpp
|
| diff --git a/Source/modules/filesystem/FileSystemCallbacks.cpp b/Source/modules/filesystem/FileSystemCallbacks.cpp
|
| index e54bee5eb9fe79f3f845fb7184f68983a068c43f..3f49b136048fd5a90acb553f1e268a58ed9bf3c2 100644
|
| --- a/Source/modules/filesystem/FileSystemCallbacks.cpp
|
| +++ b/Source/modules/filesystem/FileSystemCallbacks.cpp
|
| @@ -56,7 +56,7 @@
|
|
|
| namespace blink {
|
|
|
| -FileSystemCallbacksBase::FileSystemCallbacksBase(PassOwnPtrWillBeRawPtr<ErrorCallback> errorCallback, DOMFileSystemBase* fileSystem, ExecutionContext* context)
|
| +FileSystemCallbacksBase::FileSystemCallbacksBase(ErrorCallback* errorCallback, DOMFileSystemBase* fileSystem, ExecutionContext* context)
|
| : m_errorCallback(errorCallback)
|
| , m_fileSystem(fileSystem)
|
| , m_executionContext(context)
|
| @@ -79,7 +79,7 @@ FileSystemCallbacksBase::~FileSystemCallbacksBase()
|
| void FileSystemCallbacksBase::didFail(int code)
|
| {
|
| if (m_errorCallback)
|
| - handleEventOrScheduleCallback(m_errorCallback.release(), FileError::create(static_cast<FileError::ErrorCode>(code)));
|
| + handleEventOrScheduleCallback(m_errorCallback.get(), FileError::create(static_cast<FileError::ErrorCode>(code)));
|
| }
|
|
|
| bool FileSystemCallbacksBase::shouldScheduleCallback() const
|
| @@ -89,16 +89,16 @@ bool FileSystemCallbacksBase::shouldScheduleCallback() const
|
|
|
| #if !ENABLE(OILPAN)
|
| template <typename CB, typename CBArg>
|
| -void FileSystemCallbacksBase::handleEventOrScheduleCallback(PassOwnPtrWillBeRawPtr<CB> callback, RawPtr<CBArg> arg)
|
| +void FileSystemCallbacksBase::handleEventOrScheduleCallback(CB* callback, RawPtr<CBArg> arg)
|
| {
|
| handleEventOrScheduleCallback(callback, arg.get());
|
| }
|
| #endif
|
|
|
| template <typename CB, typename CBArg>
|
| -void FileSystemCallbacksBase::handleEventOrScheduleCallback(PassOwnPtrWillBeRawPtr<CB> callback, CBArg* arg)
|
| +void FileSystemCallbacksBase::handleEventOrScheduleCallback(CB* callback, CBArg* arg)
|
| {
|
| - ASSERT(callback.get());
|
| + ASSERT(callback);
|
| InspectorInstrumentationCookie cookie = InspectorInstrumentation::traceAsyncOperationCompletedCallbackStarting(m_executionContext.get(), m_asyncOperationId);
|
| if (shouldScheduleCallback())
|
| DOMFileSystem::scheduleCallback(m_executionContext.get(), callback, arg);
|
| @@ -109,9 +109,9 @@ void FileSystemCallbacksBase::handleEventOrScheduleCallback(PassOwnPtrWillBeRawP
|
| }
|
|
|
| template <typename CB, typename CBArg>
|
| -void FileSystemCallbacksBase::handleEventOrScheduleCallback(PassOwnPtrWillBeRawPtr<CB> callback, PassRefPtrWillBeRawPtr<CBArg> arg)
|
| +void FileSystemCallbacksBase::handleEventOrScheduleCallback(CB* callback, PassRefPtrWillBeRawPtr<CBArg> arg)
|
| {
|
| - ASSERT(callback.get());
|
| + ASSERT(callback);
|
| InspectorInstrumentationCookie cookie = InspectorInstrumentation::traceAsyncOperationCompletedCallbackStarting(m_executionContext.get(), m_asyncOperationId);
|
| if (shouldScheduleCallback())
|
| DOMFileSystem::scheduleCallback(m_executionContext.get(), callback, arg);
|
| @@ -122,9 +122,9 @@ void FileSystemCallbacksBase::handleEventOrScheduleCallback(PassOwnPtrWillBeRawP
|
| }
|
|
|
| template <typename CB>
|
| -void FileSystemCallbacksBase::handleEventOrScheduleCallback(PassOwnPtrWillBeRawPtr<CB> callback)
|
| +void FileSystemCallbacksBase::handleEventOrScheduleCallback(CB* callback)
|
| {
|
| - ASSERT(callback.get());
|
| + ASSERT(callback);
|
| InspectorInstrumentationCookie cookie = InspectorInstrumentation::traceAsyncOperationCompletedCallbackStarting(m_executionContext.get(), m_asyncOperationId);
|
| if (shouldScheduleCallback())
|
| DOMFileSystem::scheduleCallback(m_executionContext.get(), callback);
|
| @@ -136,12 +136,12 @@ void FileSystemCallbacksBase::handleEventOrScheduleCallback(PassOwnPtrWillBeRawP
|
|
|
| // EntryCallbacks -------------------------------------------------------------
|
|
|
| -PassOwnPtr<AsyncFileSystemCallbacks> EntryCallbacks::create(PassOwnPtrWillBeRawPtr<EntryCallback> successCallback, PassOwnPtrWillBeRawPtr<ErrorCallback> errorCallback, ExecutionContext* context, DOMFileSystemBase* fileSystem, const String& expectedPath, bool isDirectory)
|
| +PassOwnPtr<AsyncFileSystemCallbacks> EntryCallbacks::create(EntryCallback* successCallback, ErrorCallback* errorCallback, ExecutionContext* context, DOMFileSystemBase* fileSystem, const String& expectedPath, bool isDirectory)
|
| {
|
| return adoptPtr(new EntryCallbacks(successCallback, errorCallback, context, fileSystem, expectedPath, isDirectory));
|
| }
|
|
|
| -EntryCallbacks::EntryCallbacks(PassOwnPtrWillBeRawPtr<EntryCallback> successCallback, PassOwnPtrWillBeRawPtr<ErrorCallback> errorCallback, ExecutionContext* context, DOMFileSystemBase* fileSystem, const String& expectedPath, bool isDirectory)
|
| +EntryCallbacks::EntryCallbacks(EntryCallback* successCallback, ErrorCallback* errorCallback, ExecutionContext* context, DOMFileSystemBase* fileSystem, const String& expectedPath, bool isDirectory)
|
| : FileSystemCallbacksBase(errorCallback, fileSystem, context)
|
| , m_successCallback(successCallback)
|
| , m_expectedPath(expectedPath)
|
| @@ -153,20 +153,20 @@ void EntryCallbacks::didSucceed()
|
| {
|
| if (m_successCallback) {
|
| if (m_isDirectory)
|
| - handleEventOrScheduleCallback(m_successCallback.release(), DirectoryEntry::create(m_fileSystem, m_expectedPath));
|
| + handleEventOrScheduleCallback(m_successCallback.get(), DirectoryEntry::create(m_fileSystem, m_expectedPath));
|
| else
|
| - handleEventOrScheduleCallback(m_successCallback.release(), FileEntry::create(m_fileSystem, m_expectedPath));
|
| + handleEventOrScheduleCallback(m_successCallback.get(), FileEntry::create(m_fileSystem, m_expectedPath));
|
| }
|
| }
|
|
|
| // EntriesCallbacks -----------------------------------------------------------
|
|
|
| -PassOwnPtr<AsyncFileSystemCallbacks> EntriesCallbacks::create(PassOwnPtrWillBeRawPtr<EntriesCallback> successCallback, PassOwnPtrWillBeRawPtr<ErrorCallback> errorCallback, ExecutionContext* context, DirectoryReaderBase* directoryReader, const String& basePath)
|
| +PassOwnPtr<AsyncFileSystemCallbacks> EntriesCallbacks::create(EntriesCallback* successCallback, ErrorCallback* errorCallback, ExecutionContext* context, DirectoryReaderBase* directoryReader, const String& basePath)
|
| {
|
| return adoptPtr(new EntriesCallbacks(successCallback, errorCallback, context, directoryReader, basePath));
|
| }
|
|
|
| -EntriesCallbacks::EntriesCallbacks(PassOwnPtrWillBeRawPtr<EntriesCallback> successCallback, PassOwnPtrWillBeRawPtr<ErrorCallback> errorCallback, ExecutionContext* context, DirectoryReaderBase* directoryReader, const String& basePath)
|
| +EntriesCallbacks::EntriesCallbacks(EntriesCallback* successCallback, ErrorCallback* errorCallback, ExecutionContext* context, DirectoryReaderBase* directoryReader, const String& basePath)
|
| : FileSystemCallbacksBase(errorCallback, directoryReader->filesystem(), context)
|
| , m_successCallback(successCallback)
|
| , m_directoryReader(directoryReader)
|
| @@ -199,12 +199,12 @@ void EntriesCallbacks::didReadDirectoryEntries(bool hasMore)
|
|
|
| // FileSystemCallbacks --------------------------------------------------------
|
|
|
| -PassOwnPtr<AsyncFileSystemCallbacks> FileSystemCallbacks::create(PassOwnPtrWillBeRawPtr<FileSystemCallback> successCallback, PassOwnPtrWillBeRawPtr<ErrorCallback> errorCallback, ExecutionContext* context, FileSystemType type)
|
| +PassOwnPtr<AsyncFileSystemCallbacks> FileSystemCallbacks::create(FileSystemCallback* successCallback, ErrorCallback* errorCallback, ExecutionContext* context, FileSystemType type)
|
| {
|
| return adoptPtr(new FileSystemCallbacks(successCallback, errorCallback, context, type));
|
| }
|
|
|
| -FileSystemCallbacks::FileSystemCallbacks(PassOwnPtrWillBeRawPtr<FileSystemCallback> successCallback, PassOwnPtrWillBeRawPtr<ErrorCallback> errorCallback, ExecutionContext* context, FileSystemType type)
|
| +FileSystemCallbacks::FileSystemCallbacks(FileSystemCallback* successCallback, ErrorCallback* errorCallback, ExecutionContext* context, FileSystemType type)
|
| : FileSystemCallbacksBase(errorCallback, nullptr, context)
|
| , m_successCallback(successCallback)
|
| , m_type(type)
|
| @@ -214,17 +214,17 @@ FileSystemCallbacks::FileSystemCallbacks(PassOwnPtrWillBeRawPtr<FileSystemCallba
|
| void FileSystemCallbacks::didOpenFileSystem(const String& name, const KURL& rootURL)
|
| {
|
| if (m_successCallback)
|
| - handleEventOrScheduleCallback(m_successCallback.release(), DOMFileSystem::create(m_executionContext.get(), name, m_type, rootURL));
|
| + handleEventOrScheduleCallback(m_successCallback.get(), DOMFileSystem::create(m_executionContext.get(), name, m_type, rootURL));
|
| }
|
|
|
| // ResolveURICallbacks --------------------------------------------------------
|
|
|
| -PassOwnPtr<AsyncFileSystemCallbacks> ResolveURICallbacks::create(PassOwnPtrWillBeRawPtr<EntryCallback> successCallback, PassOwnPtrWillBeRawPtr<ErrorCallback> errorCallback, ExecutionContext* context)
|
| +PassOwnPtr<AsyncFileSystemCallbacks> ResolveURICallbacks::create(EntryCallback* successCallback, ErrorCallback* errorCallback, ExecutionContext* context)
|
| {
|
| return adoptPtr(new ResolveURICallbacks(successCallback, errorCallback, context));
|
| }
|
|
|
| -ResolveURICallbacks::ResolveURICallbacks(PassOwnPtrWillBeRawPtr<EntryCallback> successCallback, PassOwnPtrWillBeRawPtr<ErrorCallback> errorCallback, ExecutionContext* context)
|
| +ResolveURICallbacks::ResolveURICallbacks(EntryCallback* successCallback, ErrorCallback* errorCallback, ExecutionContext* context)
|
| : FileSystemCallbacksBase(errorCallback, nullptr, context)
|
| , m_successCallback(successCallback)
|
| {
|
| @@ -237,24 +237,24 @@ void ResolveURICallbacks::didResolveURL(const String& name, const KURL& rootURL,
|
|
|
| String absolutePath;
|
| if (!DOMFileSystemBase::pathToAbsolutePath(type, root, filePath, absolutePath)) {
|
| - handleEventOrScheduleCallback(m_errorCallback.release(), FileError::create(FileError::INVALID_MODIFICATION_ERR));
|
| + handleEventOrScheduleCallback(m_errorCallback.get(), FileError::create(FileError::INVALID_MODIFICATION_ERR));
|
| return;
|
| }
|
|
|
| if (isDirectory)
|
| - handleEventOrScheduleCallback(m_successCallback.release(), DirectoryEntry::create(filesystem, absolutePath));
|
| + handleEventOrScheduleCallback(m_successCallback.get(), DirectoryEntry::create(filesystem, absolutePath));
|
| else
|
| - handleEventOrScheduleCallback(m_successCallback.release(), FileEntry::create(filesystem, absolutePath));
|
| + handleEventOrScheduleCallback(m_successCallback.get(), FileEntry::create(filesystem, absolutePath));
|
| }
|
|
|
| // MetadataCallbacks ----------------------------------------------------------
|
|
|
| -PassOwnPtr<AsyncFileSystemCallbacks> MetadataCallbacks::create(PassOwnPtrWillBeRawPtr<MetadataCallback> successCallback, PassOwnPtrWillBeRawPtr<ErrorCallback> errorCallback, ExecutionContext* context, DOMFileSystemBase* fileSystem)
|
| +PassOwnPtr<AsyncFileSystemCallbacks> MetadataCallbacks::create(MetadataCallback* successCallback, ErrorCallback* errorCallback, ExecutionContext* context, DOMFileSystemBase* fileSystem)
|
| {
|
| return adoptPtr(new MetadataCallbacks(successCallback, errorCallback, context, fileSystem));
|
| }
|
|
|
| -MetadataCallbacks::MetadataCallbacks(PassOwnPtrWillBeRawPtr<MetadataCallback> successCallback, PassOwnPtrWillBeRawPtr<ErrorCallback> errorCallback, ExecutionContext* context, DOMFileSystemBase* fileSystem)
|
| +MetadataCallbacks::MetadataCallbacks(MetadataCallback* successCallback, ErrorCallback* errorCallback, ExecutionContext* context, DOMFileSystemBase* fileSystem)
|
| : FileSystemCallbacksBase(errorCallback, fileSystem, context)
|
| , m_successCallback(successCallback)
|
| {
|
| @@ -263,17 +263,17 @@ MetadataCallbacks::MetadataCallbacks(PassOwnPtrWillBeRawPtr<MetadataCallback> su
|
| void MetadataCallbacks::didReadMetadata(const FileMetadata& metadata)
|
| {
|
| if (m_successCallback)
|
| - handleEventOrScheduleCallback(m_successCallback.release(), Metadata::create(metadata));
|
| + handleEventOrScheduleCallback(m_successCallback.get(), Metadata::create(metadata));
|
| }
|
|
|
| // FileWriterBaseCallbacks ----------------------------------------------------
|
|
|
| -PassOwnPtr<AsyncFileSystemCallbacks> FileWriterBaseCallbacks::create(PassRefPtrWillBeRawPtr<FileWriterBase> fileWriter, PassOwnPtrWillBeRawPtr<FileWriterBaseCallback> successCallback, PassOwnPtrWillBeRawPtr<ErrorCallback> errorCallback, ExecutionContext* context)
|
| +PassOwnPtr<AsyncFileSystemCallbacks> FileWriterBaseCallbacks::create(PassRefPtrWillBeRawPtr<FileWriterBase> fileWriter, FileWriterBaseCallback* successCallback, ErrorCallback* errorCallback, ExecutionContext* context)
|
| {
|
| return adoptPtr(new FileWriterBaseCallbacks(fileWriter, successCallback, errorCallback, context));
|
| }
|
|
|
| -FileWriterBaseCallbacks::FileWriterBaseCallbacks(PassRefPtrWillBeRawPtr<FileWriterBase> fileWriter, PassOwnPtrWillBeRawPtr<FileWriterBaseCallback> successCallback, PassOwnPtrWillBeRawPtr<ErrorCallback> errorCallback, ExecutionContext* context)
|
| +FileWriterBaseCallbacks::FileWriterBaseCallbacks(PassRefPtrWillBeRawPtr<FileWriterBase> fileWriter, FileWriterBaseCallback* successCallback, ErrorCallback* errorCallback, ExecutionContext* context)
|
| : FileSystemCallbacksBase(errorCallback, nullptr, context)
|
| , m_fileWriter(fileWriter.get())
|
| , m_successCallback(successCallback)
|
| @@ -284,17 +284,17 @@ void FileWriterBaseCallbacks::didCreateFileWriter(PassOwnPtr<WebFileWriter> file
|
| {
|
| m_fileWriter->initialize(fileWriter, length);
|
| if (m_successCallback)
|
| - handleEventOrScheduleCallback(m_successCallback.release(), m_fileWriter.release());
|
| + handleEventOrScheduleCallback(m_successCallback.get(), m_fileWriter.release());
|
| }
|
|
|
| // SnapshotFileCallback -------------------------------------------------------
|
|
|
| -PassOwnPtr<AsyncFileSystemCallbacks> SnapshotFileCallback::create(DOMFileSystemBase* filesystem, const String& name, const KURL& url, PassOwnPtrWillBeRawPtr<FileCallback> successCallback, PassOwnPtrWillBeRawPtr<ErrorCallback> errorCallback, ExecutionContext* context)
|
| +PassOwnPtr<AsyncFileSystemCallbacks> SnapshotFileCallback::create(DOMFileSystemBase* filesystem, const String& name, const KURL& url, FileCallback* successCallback, ErrorCallback* errorCallback, ExecutionContext* context)
|
| {
|
| return adoptPtr(new SnapshotFileCallback(filesystem, name, url, successCallback, errorCallback, context));
|
| }
|
|
|
| -SnapshotFileCallback::SnapshotFileCallback(DOMFileSystemBase* filesystem, const String& name, const KURL& url, PassOwnPtrWillBeRawPtr<FileCallback> successCallback, PassOwnPtrWillBeRawPtr<ErrorCallback> errorCallback, ExecutionContext* context)
|
| +SnapshotFileCallback::SnapshotFileCallback(DOMFileSystemBase* filesystem, const String& name, const KURL& url, FileCallback* successCallback, ErrorCallback* errorCallback, ExecutionContext* context)
|
| : FileSystemCallbacksBase(errorCallback, filesystem, context)
|
| , m_name(name)
|
| , m_url(url)
|
| @@ -312,17 +312,17 @@ void SnapshotFileCallback::didCreateSnapshotFile(const FileMetadata& metadata, P
|
| // *after* we've coined a File with a new handle that has the correct type set on it. This allows the
|
| // blob storage system to track when a temp file can and can't be safely deleted.
|
|
|
| - handleEventOrScheduleCallback(m_successCallback.release(), DOMFileSystemBase::createFile(metadata, m_url, m_fileSystem->type(), m_name));
|
| + handleEventOrScheduleCallback(m_successCallback.get(), DOMFileSystemBase::createFile(metadata, m_url, m_fileSystem->type(), m_name));
|
| }
|
|
|
| // VoidCallbacks --------------------------------------------------------------
|
|
|
| -PassOwnPtr<AsyncFileSystemCallbacks> VoidCallbacks::create(PassOwnPtrWillBeRawPtr<VoidCallback> successCallback, PassOwnPtrWillBeRawPtr<ErrorCallback> errorCallback, ExecutionContext* context, DOMFileSystemBase* fileSystem)
|
| +PassOwnPtr<AsyncFileSystemCallbacks> VoidCallbacks::create(VoidCallback* successCallback, ErrorCallback* errorCallback, ExecutionContext* context, DOMFileSystemBase* fileSystem)
|
| {
|
| return adoptPtr(new VoidCallbacks(successCallback, errorCallback, context, fileSystem));
|
| }
|
|
|
| -VoidCallbacks::VoidCallbacks(PassOwnPtrWillBeRawPtr<VoidCallback> successCallback, PassOwnPtrWillBeRawPtr<ErrorCallback> errorCallback, ExecutionContext* context, DOMFileSystemBase* fileSystem)
|
| +VoidCallbacks::VoidCallbacks(VoidCallback* successCallback, ErrorCallback* errorCallback, ExecutionContext* context, DOMFileSystemBase* fileSystem)
|
| : FileSystemCallbacksBase(errorCallback, fileSystem, context)
|
| , m_successCallback(successCallback)
|
| {
|
| @@ -331,7 +331,7 @@ VoidCallbacks::VoidCallbacks(PassOwnPtrWillBeRawPtr<VoidCallback> successCallbac
|
| void VoidCallbacks::didSucceed()
|
| {
|
| if (m_successCallback)
|
| - handleEventOrScheduleCallback(m_successCallback.release());
|
| + handleEventOrScheduleCallback(m_successCallback.get());
|
| }
|
|
|
| } // namespace blink
|
|
|