Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2172)

Unified Diff: Source/modules/filesystem/DOMFileSystem.h

Issue 563703002: Oilpan: Enable oilpan for callback classes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/filesystem/DOMFileSystem.h
diff --git a/Source/modules/filesystem/DOMFileSystem.h b/Source/modules/filesystem/DOMFileSystem.h
index 3b02eb5c06f7247d260183a4f3d4f5e5cc4bccd5..9a529536f5174bbe6283fa47e4e1e6d911ad4308 100644
--- a/Source/modules/filesystem/DOMFileSystem.h
+++ b/Source/modules/filesystem/DOMFileSystem.h
@@ -60,45 +60,45 @@ public:
// DOMFileSystemBase overrides.
virtual void addPendingCallbacks() OVERRIDE;
virtual void removePendingCallbacks() OVERRIDE;
- virtual void reportError(PassOwnPtrWillBeRawPtr<ErrorCallback>, PassRefPtrWillBeRawPtr<FileError>) OVERRIDE;
+ virtual void reportError(ErrorCallback*, PassRefPtrWillBeRawPtr<FileError>) OVERRIDE;
// ActiveDOMObject overrides.
virtual bool hasPendingActivity() const OVERRIDE;
- void createWriter(const FileEntry*, PassOwnPtrWillBeRawPtr<FileWriterCallback>, PassOwnPtrWillBeRawPtr<ErrorCallback>);
- void createFile(const FileEntry*, PassOwnPtrWillBeRawPtr<FileCallback>, PassOwnPtrWillBeRawPtr<ErrorCallback>);
+ void createWriter(const FileEntry*, FileWriterCallback*, ErrorCallback*);
+ void createFile(const FileEntry*, FileCallback*, ErrorCallback*);
// Schedule a callback. This should not cross threads (should be called on the same context thread).
// FIXME: move this to a more generic place.
template <typename CB, typename CBArg>
- static void scheduleCallback(ExecutionContext*, PassOwnPtrWillBeRawPtr<CB>, PassRefPtrWillBeRawPtr<CBArg>);
+ static void scheduleCallback(ExecutionContext*, CB*, PassRefPtrWillBeRawPtr<CBArg>);
template <typename CB, typename CBArg>
- static void scheduleCallback(ExecutionContext*, PassOwnPtrWillBeRawPtr<CB>, CBArg*);
+ static void scheduleCallback(ExecutionContext*, CB*, CBArg*);
template <typename CB, typename CBArg>
- static void scheduleCallback(ExecutionContext*, PassOwnPtrWillBeRawPtr<CB>, const HeapVector<CBArg>&);
+ static void scheduleCallback(ExecutionContext*, CB*, const HeapVector<CBArg>&);
template <typename CB, typename CBArg>
- static void scheduleCallback(ExecutionContext*, PassOwnPtrWillBeRawPtr<CB>, const CBArg&);
+ static void scheduleCallback(ExecutionContext*, CB*, const CBArg&);
template <typename CB>
- static void scheduleCallback(ExecutionContext*, PassOwnPtrWillBeRawPtr<CB>);
+ static void scheduleCallback(ExecutionContext*, CB*);
template <typename CB, typename CBArg>
- void scheduleCallback(PassOwnPtrWillBeRawPtr<CB> callback, PassRefPtrWillBeRawPtr<CBArg> callbackArg)
+ void scheduleCallback(CB* callback, PassRefPtrWillBeRawPtr<CBArg> callbackArg)
{
scheduleCallback(executionContext(), callback, callbackArg);
}
template <typename CB, typename CBArg>
- void scheduleCallback(PassOwnPtrWillBeRawPtr<CB> callback, CBArg* callbackArg)
+ void scheduleCallback(CB* callback, CBArg* callbackArg)
{
scheduleCallback(executionContext(), callback, callbackArg);
}
template <typename CB, typename CBArg>
- void scheduleCallback(PassOwnPtrWillBeRawPtr<CB> callback, const CBArg& callbackArg)
+ void scheduleCallback(CB* callback, const CBArg& callbackArg)
{
scheduleCallback(executionContext(), callback, callbackArg);
}
@@ -126,7 +126,7 @@ private:
template <typename CB, typename CBArg>
class DispatchCallbackRefPtrArgTask FINAL : public DispatchCallbackTaskBase {
public:
- DispatchCallbackRefPtrArgTask(PassOwnPtrWillBeRawPtr<CB> callback, PassRefPtrWillBeRawPtr<CBArg> arg)
+ DispatchCallbackRefPtrArgTask(CB* callback, PassRefPtrWillBeRawPtr<CBArg> arg)
: m_callback(callback)
, m_callbackArg(arg)
{
@@ -138,14 +138,14 @@ private:
}
private:
- OwnPtrWillBePersistent<CB> m_callback;
+ Persistent<CB> m_callback;
RefPtrWillBePersistent<CBArg> m_callbackArg;
};
template <typename CB, typename CBArg>
class DispatchCallbackPtrArgTask FINAL : public DispatchCallbackTaskBase {
public:
- DispatchCallbackPtrArgTask(PassOwnPtrWillBeRawPtr<CB> callback, CBArg* arg)
+ DispatchCallbackPtrArgTask(CB* callback, CBArg* arg)
: m_callback(callback)
, m_callbackArg(arg)
{
@@ -157,14 +157,14 @@ private:
}
private:
- OwnPtrWillBePersistent<CB> m_callback;
+ Persistent<CB> m_callback;
Persistent<CBArg> m_callbackArg;
};
template <typename CB, typename CBArg>
class DispatchCallbackNonPtrArgTask FINAL : public DispatchCallbackTaskBase {
public:
- DispatchCallbackNonPtrArgTask(PassOwnPtrWillBeRawPtr<CB> callback, const CBArg& arg)
+ DispatchCallbackNonPtrArgTask(CB* callback, const CBArg& arg)
: m_callback(callback)
, m_callbackArg(arg)
{
@@ -176,14 +176,14 @@ private:
}
private:
- OwnPtrWillBePersistent<CB> m_callback;
+ Persistent<CB> m_callback;
CBArg m_callbackArg;
};
template <typename CB>
class DispatchCallbackNoArgTask FINAL : public DispatchCallbackTaskBase {
public:
- DispatchCallbackNoArgTask(PassOwnPtrWillBeRawPtr<CB> callback)
+ DispatchCallbackNoArgTask(CB* callback)
: m_callback(callback)
{
}
@@ -194,14 +194,14 @@ private:
}
private:
- OwnPtrWillBePersistent<CB> m_callback;
+ Persistent<CB> m_callback;
};
int m_numberOfPendingCallbacks;
};
template <typename CB, typename CBArg>
-void DOMFileSystem::scheduleCallback(ExecutionContext* executionContext, PassOwnPtrWillBeRawPtr<CB> callback, PassRefPtrWillBeRawPtr<CBArg> arg)
+void DOMFileSystem::scheduleCallback(ExecutionContext* executionContext, CB* callback, PassRefPtrWillBeRawPtr<CBArg> arg)
{
ASSERT(executionContext->isContextThread());
if (callback)
@@ -209,7 +209,7 @@ void DOMFileSystem::scheduleCallback(ExecutionContext* executionContext, PassOwn
}
template <typename CB, typename CBArg>
-void DOMFileSystem::scheduleCallback(ExecutionContext* executionContext, PassOwnPtrWillBeRawPtr<CB> callback, CBArg* arg)
+void DOMFileSystem::scheduleCallback(ExecutionContext* executionContext, CB* callback, CBArg* arg)
{
ASSERT(executionContext->isContextThread());
if (callback)
@@ -217,7 +217,7 @@ void DOMFileSystem::scheduleCallback(ExecutionContext* executionContext, PassOwn
}
template <typename CB, typename CBArg>
-void DOMFileSystem::scheduleCallback(ExecutionContext* executionContext, PassOwnPtrWillBeRawPtr<CB> callback, const HeapVector<CBArg>& arg)
+void DOMFileSystem::scheduleCallback(ExecutionContext* executionContext, CB* callback, const HeapVector<CBArg>& arg)
{
ASSERT(executionContext->isContextThread());
if (callback)
@@ -225,7 +225,7 @@ void DOMFileSystem::scheduleCallback(ExecutionContext* executionContext, PassOwn
}
template <typename CB, typename CBArg>
-void DOMFileSystem::scheduleCallback(ExecutionContext* executionContext, PassOwnPtrWillBeRawPtr<CB> callback, const CBArg& arg)
+void DOMFileSystem::scheduleCallback(ExecutionContext* executionContext, CB* callback, const CBArg& arg)
{
ASSERT(executionContext->isContextThread());
if (callback)
@@ -233,7 +233,7 @@ void DOMFileSystem::scheduleCallback(ExecutionContext* executionContext, PassOwn
}
template <typename CB>
-void DOMFileSystem::scheduleCallback(ExecutionContext* executionContext, PassOwnPtrWillBeRawPtr<CB> callback)
+void DOMFileSystem::scheduleCallback(ExecutionContext* executionContext, CB* callback)
{
ASSERT(executionContext->isContextThread());
if (callback)
« no previous file with comments | « Source/core/inspector/InspectorResourceContentLoader.cpp ('k') | Source/modules/filesystem/DOMFileSystem.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698