Source/bindings/scripts/v8_methods.py - Issue 563703002: Oilpan: Enable oilpan for callback classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 563703002: Oilpan: Enable oilpan for callback classes (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_methods.py

diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py

index e787919cde690e6be3f3160d0ad2bca53baa6efc..6fb534689a4b26a26a94dc95450b178a42535c6e 100644

--- a/Source/bindings/scripts/v8_methods.py

+++ b/Source/bindings/scripts/v8_methods.py

@@ -296,8 +296,7 @@ def cpp_value(interface, method, number_of_arguments):

return argument.name

if idl_type.is_dictionary:

return '*%s' % argument.name

- if (idl_type.is_callback_interface or

- idl_type.name in ['NodeFilter', 'NodeFilterOrNull',

+ if (idl_type.name in ['NodeFilter', 'NodeFilterOrNull',

'XPathNSResolver', 'XPathNSResolverOrNull']):

# FIXME: remove this special case

return '%s.release()' % argument.name