Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Side by Side Diff: Source/bindings/modules/v8/custom/V8SQLTransactionCustom.cpp

Issue 563703002: Oilpan: Enable oilpan for callback classes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 TONATIVE_VOID(double, sqlValue, value->NumberValue()); 84 TONATIVE_VOID(double, sqlValue, value->NumberValue());
85 sqlValues.append(SQLValue(sqlValue)); 85 sqlValues.append(SQLValue(sqlValue));
86 } else { 86 } else {
87 TOSTRING_VOID(V8StringResource<>, sqlValue, value); 87 TOSTRING_VOID(V8StringResource<>, sqlValue, value);
88 sqlValues.append(SQLValue(sqlValue)); 88 sqlValues.append(SQLValue(sqlValue));
89 } 89 }
90 } 90 }
91 } 91 }
92 92
93 SQLTransaction* transaction = V8SQLTransaction::toImpl(info.Holder()); 93 SQLTransaction* transaction = V8SQLTransaction::toImpl(info.Holder());
94 OwnPtrWillBeRawPtr<SQLStatementCallback> callback = nullptr; 94 SQLStatementCallback* callback = nullptr;
Jens Widell 2014/09/19 09:07:55 Nit: Could you align this custom code to what the
keishi 2014/09/19 10:30:07 Done.
95 if (info.Length() > 2 && !isUndefinedOrNull(info[2])) { 95 if (info.Length() > 2 && !isUndefinedOrNull(info[2])) {
96 if (!info[2]->IsFunction()) { 96 if (!info[2]->IsFunction()) {
97 exceptionState.throwDOMException(TypeMismatchError, "The 'callback' (2nd) argument provided is not a function."); 97 exceptionState.throwDOMException(TypeMismatchError, "The 'callback' (2nd) argument provided is not a function.");
98 exceptionState.throwIfNeeded(); 98 exceptionState.throwIfNeeded();
99 return; 99 return;
100 } 100 }
101 callback = V8SQLStatementCallback::create(v8::Handle<v8::Function>::Cast (info[2]), ScriptState::current(info.GetIsolate())); 101 callback = V8SQLStatementCallback::create(v8::Handle<v8::Function>::Cast (info[2]), ScriptState::current(info.GetIsolate()));
102 } 102 }
103 103
104 OwnPtrWillBeRawPtr<SQLStatementErrorCallback> errorCallback = nullptr; 104 SQLStatementErrorCallback* errorCallback = nullptr;
105 if (info.Length() > 3 && !isUndefinedOrNull(info[3])) { 105 if (info.Length() > 3 && !isUndefinedOrNull(info[3])) {
106 if (!info[3]->IsFunction()) { 106 if (!info[3]->IsFunction()) {
107 exceptionState.throwDOMException(TypeMismatchError, "The 'errorCallb ack' (3rd) argument provided is not a function."); 107 exceptionState.throwDOMException(TypeMismatchError, "The 'errorCallb ack' (3rd) argument provided is not a function.");
108 exceptionState.throwIfNeeded(); 108 exceptionState.throwIfNeeded();
109 return; 109 return;
110 } 110 }
111 errorCallback = V8SQLStatementErrorCallback::create(v8::Handle<v8::Funct ion>::Cast(info[3]), ScriptState::current(info.GetIsolate())); 111 errorCallback = V8SQLStatementErrorCallback::create(v8::Handle<v8::Funct ion>::Cast(info[3]), ScriptState::current(info.GetIsolate()));
112 } 112 }
113 113
114 transaction->executeSQL(statement, sqlValues, callback.release(), errorCallb ack.release(), exceptionState); 114 transaction->executeSQL(statement, sqlValues, callback, errorCallback, excep tionState);
115 exceptionState.throwIfNeeded(); 115 exceptionState.throwIfNeeded();
116 } 116 }
117 117
118 } // namespace blink 118 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698