Oilpan: Enable oilpan for callback classes

Source/bindings/templates/methods.cpp

 {##############################################################################}
 {% macro generate_method(method, world_suffix) %}
 {% filter conditional(method.conditional_string) %}
 static void {{method.name}}{{method.overload_index}}Method{{world_suffix}}(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     {# Local variables #}
     {% if method.has_exception_state %}
     ExceptionState exceptionState(ExceptionState::ExecutionContext, "{{method.name}}", "{{interface_name}}", info.Holder(), info.GetIsolate());
     {% endif %}
     {# Overloaded methods have length checked during overload resolution #}
@@ skipping 71 matching lines @@
 {% endmacro %}
 
 
 {######################################}
 {% macro generate_argument_var_declaration(argument) %}
 {% if argument.is_callback_interface %}
 {# FIXME: remove EventListener special case #}
 {% if argument.idl_type == 'EventListener' %}
 RefPtr<{{argument.idl_type}}> {{argument.name}}
 {%- else %}
-OwnPtrWillBeRawPtr<{{argument.idl_type}}> {{argument.name}} = nullptr;
+{{argument.idl_type}}* {{argument.name}} = nullptr;

[sof, 2014/09/18 11:38:54]

nit: ";" at the end appears redundant.

[Jens Widell, 2014/09/18 12:13:19]

I think we can (and should) remove the special handling for callback interfaces
here, keeping just the special case for EventListener.

The only difference would be that the explicit nullptr initialization goes away,
but it's only necessary because of other special cases for callback interfaces,
where we can add it instead.

[keishi, 2014/09/19 06:43:34]

Done.

 {%- endif %}{# argument.idl_type == 'EventListener' #}
 {%- else %}
 {{argument.cpp_type}} {{argument.name}}
 {%- endif %}
 {% endmacro %}
 
 
 {######################################}
 {% macro generate_argument(method, argument, world_suffix) %}
 {% if argument.is_optional and not argument.has_default and
@@ skipping 30 matching lines @@
 {% if argument.idl_type == 'EventListener' %}
 {% if method.name == 'removeEventListener' or method.name == 'removeListener' %}
 {{argument.name}} = V8EventListenerList::getEventListener(ScriptState::current(info.GetIsolate()), info[{{argument.index}}], false, ListenerFindOnly);
 {% else %}{# method.name == 'addEventListener' #}
 {{argument.name}} = V8EventListenerList::getEventListener(ScriptState::current(info.GetIsolate()), info[{{argument.index}}], false, ListenerFindOrCreate);
 {% endif %}{# method.name #}
 {% else %}{# argument.idl_type == 'EventListener' #}
 {# Callback functions must be functions:
    http://www.w3.org/TR/WebIDL/#es-callback-function #}
 {% if argument.is_optional %}
 if (info.Length() > {{argument.index}} && !isUndefinedOrNull(info[{{argument.index}}])) {

[Jens Widell, 2014/09/18 12:13:19]

We could skip the "info.Length() > {{argument.index}} &&" part here. If the
argument is missing, "info[{{argument.index}}]" will be undefined, so the
isUndefinedOrNull() check is enough.

This matches how we handle optional arguments with default values in
generate_arguments().

[keishi, 2014/09/19 06:44:15]

Done.

     if (!info[{{argument.index}}]->IsFunction()) {
         {{throw_type_error(method,
               '"The callback provided as parameter %s is not a function."' %
                   (argument.index + 1)) | indent(8)}}
         return;
     }
     {{argument.name}} = V8{{argument.idl_type}}::create(v8::Handle<v8::Function>::Cast(info[{{argument.index}}]), ScriptState::current(info.GetIsolate()));
 }

[Jens Widell, 2014/09/18 12:13:19]

Change this to

  } else {
    {{argument.name}} = nullptr;
  }

to replace the nullptr initialization in generate_argument_var_declaration().

[keishi, 2014/09/19 06:43:34]

Done.

 {% else %}{# argument.is_optional #}
 if (info.Length() <= {{argument.index}} || !{% if argument.is_nullable %}(info[{{argument.index}}]->IsFunction() || info[{{argument.index}}]->IsNull()){% else %}info[{{argument.index}}]->IsFunction(){% endif %}) {
     {{throw_type_error(method,
           '"The callback provided as parameter %s is not a function."' %
               (argument.index + 1)) | indent }}
     return;
 }
 {{argument.name}} = {% if argument.is_nullable %}info[{{argument.index}}]->IsNull() ? nullptr : {% endif %}V8{{argument.idl_type}}::create(v8::Handle<v8::Function>::Cast(info[{{argument.index}}]), ScriptState::current(info.GetIsolate()));
 {% endif %}{# argument.is_optional #}
 {% endif %}{# argument.idl_type == 'EventListener' #}
@@ skipping 475 matching lines @@
   if method.is_per_world_bindings else '0' %}
 {% set property_attribute =
   'static_cast<v8::PropertyAttribute>(%s)' % ' | '.join(method.property_attributes)
   if method.property_attributes else 'v8::None' %}
 {% set only_exposed_to_private_script = 'V8DOMConfiguration::OnlyExposedToPrivateScript' if method.only_exposed_to_private_script else 'V8DOMConfiguration::ExposedToAllScripts' %}
 static const V8DOMConfiguration::MethodConfiguration {{method.name}}MethodConfiguration = {
     "{{method.name}}", {{method_callback}}, {{method_callback_for_main_world}}, {{method.length}}, {{only_exposed_to_private_script}},
 };
 V8DOMConfiguration::installMethod({{method.function_template}}, {{method.signature}}, {{property_attribute}}, {{method.name}}MethodConfiguration, isolate);
 {%- endmacro %}