Document cellular properties

Document cellular properties

Currently the Cellular properties are not documented in onc_spec.html
at all. This provides rudimentary documentation based on the Shill
documentaiton.

It also removes 'SelectedNetwork' which is undocumented in Shill and
unused in Chrome.

BUG=None

Committed: https://crrev.com/2a84818142a4da73d6cd475672b2931271a091cc
Cr-Commit-Position: refs/heads/master@{#294516}

[stevenjb, 2014-09-10 22:33:47]

stevenjb@chromium.org changed reviewers:
+ armansito@chromium.org, pneubeck@chromium.org

[armansito, 2014-09-11 17:10:25]

https://codereview.chromium.org/563643002/diff/1/components/onc/docs/onc_spec...
File components/onc/docs/onc_spec.html (right):

https://codereview.chromium.org/563643002/diff/1/components/onc/docs/onc_spec...
components/onc/docs/onc_spec.html:1882: Currently active APN to be used with a
GSM carrier for making data
Spell out "Access Point Name"

https://codereview.chromium.org/563643002/diff/1/components/onc/docs/onc_spec...
components/onc/docs/onc_spec.html:1907: Activation state.
Would say "Carrier account activation state"

https://codereview.chromium.org/563643002/diff/1/components/onc/docs/onc_spec...
components/onc/docs/onc_spec.html:1965: if <span class="field">Family</span> is
<span class="value">GSM</span>)
Isn't this also true for LTE during roaming?

https://codereview.chromium.org/563643002/diff/1/components/onc/docs/onc_spec...
components/onc/docs/onc_spec.html:1976: The hardware revision of the modem.
"modem" -> "cellular modem"?

[stevenjb, 2014-09-11 17:33:35]

https://codereview.chromium.org/563643002/diff/1/components/onc/docs/onc_spec...
File components/onc/docs/onc_spec.html (right):

https://codereview.chromium.org/563643002/diff/1/components/onc/docs/onc_spec...
components/onc/docs/onc_spec.html:1882: Currently active APN to be used with a
GSM carrier for making data
On 2014/09/11 17:10:25, armansito wrote:
> Spell out "Access Point Name"

Except it's not just the Name, it's the "APN object". I will make that explicit.

https://codereview.chromium.org/563643002/diff/1/components/onc/docs/onc_spec...
components/onc/docs/onc_spec.html:1907: Activation state.
On 2014/09/11 17:10:25, armansito wrote:
> Would say "Carrier account activation state"

Done.

https://codereview.chromium.org/563643002/diff/1/components/onc/docs/onc_spec...
components/onc/docs/onc_spec.html:1965: if <span class="field">Family</span> is
<span class="value">GSM</span>)
On 2014/09/11 17:10:25, armansito wrote:
> Isn't this also true for LTE during roaming?

You tell me :) I based this off of what is in device-api.txt:

		array{dict} Cellular.FoundNetworks [readonly] [GSM only]

			(Cellular only) The result of the most recent
			scan operation. The property is an array
			of dictionaries, with each (string, string) entry
			from the following properties:

https://codereview.chromium.org/563643002/diff/1/components/onc/docs/onc_spec...
components/onc/docs/onc_spec.html:1976: The hardware revision of the modem.
On 2014/09/11 17:10:25, armansito wrote:
> "modem" -> "cellular modem"?

Done throughout.

[armansito, 2014-09-11 17:41:04]

armansito@chromium.org changed reviewers:
+ benchan@chromium.org

[armansito, 2014-09-11 17:41:05]

lgtm.

benchan@: PTAL the comment thread at onc_spec.html line 1965 in patch set 1.

https://codereview.chromium.org/563643002/diff/1/components/onc/docs/onc_spec...
File components/onc/docs/onc_spec.html (right):

https://codereview.chromium.org/563643002/diff/1/components/onc/docs/onc_spec...
components/onc/docs/onc_spec.html:1965: if <span class="field">Family</span> is
<span class="value">GSM</span>)
On 2014/09/11 17:33:35, stevenjb wrote:
> On 2014/09/11 17:10:25, armansito wrote:
> > Isn't this also true for LTE during roaming?
> 
> You tell me :) I based this off of what is in device-api.txt:
> 
> 		array{dict} Cellular.FoundNetworks [readonly] [GSM only]
> 
> 			(Cellular only) The result of the most recent
> 			scan operation. The property is an array
> 			of dictionaries, with each (string, string) entry
> 			from the following properties:

:) I think it should apply to LTE as well. Probably once you mention GSM you
don't have to also specify LTE (referring to the use of GSM/LTE in the
description of "ICCID" below), so I'd check with benchan@.

Whatever, leave this one as it is.

[stevenjb, 2014-09-11 21:19:09]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-09-11 21:31:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/563643002/40001

[commit-bot: I haz the power, 2014-09-11 23:49:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-11 23:49:59]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[stevenjb, 2014-09-12 00:04:47]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-09-12 00:14:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/563643002/40001

[commit-bot: I haz the power, 2014-09-12 01:13:50]

Committed patchset #3 (id:40001) as ee154b01d6dd868fc0263fdfa50a28c0b442bc71

[commit-bot: I haz the power, 2014-09-12 01:15:28]

Patchset 3 (id:??) landed as
https://crrev.com/2a84818142a4da73d6cd475672b2931271a091cc
Cr-Commit-Position: refs/heads/master@{#294516}