Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 563633003: Assert SkTDArray::pop() doesn't underflow. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Assert SkTDArray::pop() doesn't underflow. BUG=skia: Committed: https://skia.googlesource.com/skia/+/aa90d00f14414db39b3d990d8d5fd594d6eadc6e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M include/core/SkTDArray.h View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mtklein
6 years, 3 months ago (2014-09-10 20:57:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/563633003/1
6 years, 3 months ago (2014-09-10 20:58:35 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-10 20:58:36 UTC) #5
commit-bot: I haz the power
Presubmit check for 563633003-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 3 months ago (2014-09-10 20:58:40 UTC) #7
reed1
lgtm
6 years, 3 months ago (2014-09-11 13:26:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563633003/1
6 years, 3 months ago (2014-09-11 13:27:30 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 13:36:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as aa90d00f14414db39b3d990d8d5fd594d6eadc6e

Powered by Google App Engine
This is Rietveld 408576698