Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 563583002: NaCl: Remove old SRPC-based name service test that checks for SecureRandom (Closed)

Created:
6 years, 3 months ago by Mark Seaborn
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

NaCl: Remove old SRPC-based name service test that checks for SecureRandom SecureRandom is being removed from the name service on the NaCl side. This test also checks for ManifestNameService, which we are in the process of replacing with a Chrome-IPC-based implementation. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3864 BUG=394130 TEST=browser_tests Committed: https://crrev.com/7f4be8f2b44fb0b0ec585b3877b102726782d3c7 Cr-Commit-Position: refs/heads/master@{#294212}

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -351 lines) Patch
M chrome/test/data/nacl/nacl_test_data.gyp View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/test/data/nacl/nameservice/pm_nameservice_test.cc View 1 chunk +0 lines, -232 lines 0 comments Download
D chrome/test/data/nacl/nameservice/pm_nameservice_test.html View 1 chunk +0 lines, -75 lines 0 comments Download
M chrome/test/nacl/nacl_browsertest.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Mark Seaborn
6 years, 3 months ago (2014-09-10 17:27:55 UTC) #2
Roland McGrath
lgtm
6 years, 3 months ago (2014-09-10 17:37:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/563583002/20001
6 years, 3 months ago (2014-09-10 17:41:36 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-10 17:41:38 UTC) #7
teravest
lgtm
6 years, 3 months ago (2014-09-10 18:43:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/563583002/20001
6 years, 3 months ago (2014-09-10 18:52:44 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 3b1894e3b0e44d01d53afb33b6b0c1b01db5acaf
6 years, 3 months ago (2014-09-10 20:03:04 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 20:18:47 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7f4be8f2b44fb0b0ec585b3877b102726782d3c7
Cr-Commit-Position: refs/heads/master@{#294212}

Powered by Google App Engine
This is Rietveld 408576698