Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 563573002: Do full GC for small heaps in idle time handler. (Closed)

Created:
6 years, 3 months ago by ulan
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Do full GC for small heaps in idle time handler. BUG=407593 LOG=N R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23871

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/heap/gc-idle-time-handler.cc View 1 chunk +4 lines, -1 line 1 comment Download

Messages

Total messages: 3 (1 generated)
Hannes Payer (out of office)
LGTM, one nit https://codereview.chromium.org/563573002/diff/1/src/heap/gc-idle-time-handler.cc File src/heap/gc-idle-time-handler.cc (right): https://codereview.chromium.org/563573002/diff/1/src/heap/gc-idle-time-handler.cc#newcode81 src/heap/gc-idle-time-handler.cc:81: const size_t kSmallHeap = 2 * ...
6 years, 3 months ago (2014-09-11 09:21:59 UTC) #2
ulan
6 years, 3 months ago (2014-09-11 11:54:58 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 23871 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698