chrome/browser/chromeos/login/screenshot_tester.cc - Issue 563553005: Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/login

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/screenshot_tester.cc

Issue 563553005: Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/login (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/lock/screen_locker.cc ('k') | chrome/browser/chromeos/login/session/user_session_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/screenshot_tester.cc

diff --git a/chrome/browser/chromeos/login/screenshot_tester.cc b/chrome/browser/chromeos/login/screenshot_tester.cc

index cfc4cf2da83b972eb569186c63ed0727bc8ec1a2..f8961807c4eee26ddb18e232e13a73cafe827ad1 100644

--- a/chrome/browser/chromeos/login/screenshot_tester.cc

+++ b/chrome/browser/chromeos/login/screenshot_tester.cc

@@ -105,7 +105,7 @@ bool ScreenshotTester::SaveImage(const std::string& file_name,

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

base::FilePath screenshot_path =

screenshot_dir.AppendASCII(test_name_ + "_" + file_name + ".png");

- if (!png_data) {

+ if (!png_data.get()) {

LOG(ERROR) << "Can't take a screenshot";

return false;

}