Some additional network settings cleanup

Some additional network settings cleanup

Just some additional code cleanup in preparation for adding a separate
requestor for carrier info and other remaining non ONC data.

BUG=279351
Committed: https://crrev.com/3ac3cdcf52bc4f0b930df951dba8d9d9f11520fc
Cr-Commit-Position: refs/heads/master@{#294504}

[stevenjb, 2014-09-10 22:44:25]

stevenjb@chromium.org changed reviewers:
+ armansito@chromium.org, pneubeck@chromium.org

[armansito, 2014-09-11 17:01:15]

https://codereview.chromium.org/563553004/diff/40001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/563553004/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.js:405: var isVPN =
this.type_ == 'VPN';
Maybe add instance methods for these, which you can then reuse in updateDetails_
below. (e.g. if (this.isCellular())).

[stevenjb, 2014-09-11 17:22:33]

https://codereview.chromium.org/563553004/diff/40001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/563553004/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.js:405: var isVPN =
this.type_ == 'VPN';
On 2014/09/11 17:01:15, armansito wrote:
> Maybe add instance methods for these, which you can then reuse in
updateDetails_
> below. (e.g. if (this.isCellular())).
Hm. I really only pulled these out for brevity in some of the code here;
this.isCellular() would defeat that purpose. I'd rather just eliminate these if
they are confusing.

[armansito, 2014-09-11 17:28:12]

https://codereview.chromium.org/563553004/diff/40001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/563553004/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.js:405: var isVPN =
this.type_ == 'VPN';
On 2014/09/11 17:22:33, stevenjb wrote:
> On 2014/09/11 17:01:15, armansito wrote:
> > Maybe add instance methods for these, which you can then reuse in
> updateDetails_
> > below. (e.g. if (this.isCellular())).
> Hm. I really only pulled these out for brevity in some of the code here;
> this.isCellular() would defeat that purpose. I'd rather just eliminate these
if
> they are confusing.
> 

Up to you then. I'd just be consistent here and below, i.e. either always use
the explicit comparison or have the temporaries.

[stevenjb, 2014-09-11 17:38:23]

https://codereview.chromium.org/563553004/diff/40001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/563553004/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.js:405: var isVPN =
this.type_ == 'VPN';
On 2014/09/11 17:28:12, armansito wrote:
> On 2014/09/11 17:22:33, stevenjb wrote:
> > On 2014/09/11 17:01:15, armansito wrote:
> > > Maybe add instance methods for these, which you can then reuse in
> > updateDetails_
> > > below. (e.g. if (this.isCellular())).
> > Hm. I really only pulled these out for brevity in some of the code here;
> > this.isCellular() would defeat that purpose. I'd rather just eliminate these
> if
> > they are confusing.
> > 
> 
> Up to you then. I'd just be consistent here and below, i.e. either always use
> the explicit comparison or have the temporaries.
Removed.

[armansito, 2014-09-11 17:45:47]

lgtm

[stevenjb, 2014-09-11 21:16:34]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-09-11 21:31:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/563553004/80001

[commit-bot: I haz the power, 2014-09-12 00:41:52]

Committed patchset #5 (id:80001) as 831efa715ac62161c0703350b4fc639d5cf1d384

[commit-bot: I haz the power, 2014-09-12 00:45:57]

Patchset 5 (id:??) landed as
https://crrev.com/3ac3cdcf52bc4f0b930df951dba8d9d9f11520fc
Cr-Commit-Position: refs/heads/master@{#294504}