Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 5635002: Merge 73112 - 2010-12-02 Adam Barth <abarth@webkit.org>... (Closed)

Created:
10 years ago by abarth-chromium
Modified:
9 years, 7 months ago
Reviewers:
abarth
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/597/
Visibility:
Public.

Description

Merge 73112 - 2010-12-02 Adam Barth <abarth@webkit.org>; Reviewed by Eric Seidel. Gray-scale JPEG images with a color profile are stretched horizonally https://bugs.webkit.org/show_bug.cgi?id=49950 Turns out gray-scale JPEGs with color profiles have the same issue as PNGs. As with PNGs, we suppress now suppress the color profile for gray-scale JPEGs. Most importantly, this patch adds a test. Test: fast/images/gray-scale-jpeg-with-color-profile.html * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode): 2010-12-02 Adam Barth <abarth@webkit.org>; Reviewed by Eric Seidel. Gray-scale JPEG images with a color profile are stretched horizonally https://bugs.webkit.org/show_bug.cgi?id=49950 Test that we properly render gray-scale JPEGs with embedded color profiles. * fast/images/gray-scale-jpeg-with-color-profile.html: Added. * fast/images/resources/flowchart.jpg: Added. * platform/mac/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Added. TBR=abarth@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73243

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, --2 lines) Patch
A + LayoutTests/fast/images/gray-scale-jpeg-with-color-profile.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/images/resources/flowchart.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/fast/images/gray-scale-jpeg-with-color-profile-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M WebCore/platform/image-decoders/ImageDecoder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
abarth-chromium
10 years ago (2010-12-03 07:21:45 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698