Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 563463003: DevTools: extract TracingManager from TracingModel, step 2 (Closed)

Created:
6 years, 3 months ago by caseq
Modified:
6 years, 3 months ago
Reviewers:
yurys, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: extract TracingManager from TracingModel, step 2 This just moves code from sdk/TracingModel.js to timeline/TracingModel.js and renames the former to sdk/TracingManager.js. No actual code was harmed. BUG=412709 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181797

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -1004 lines) Patch
M Source/devtools/devtools.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/inspector.html View 1 chunk +1 line, -1 line 0 comments Download
A Source/devtools/front_end/sdk/TracingManager.js View 1 chunk +168 lines, -0 lines 1 comment Download
D Source/devtools/front_end/sdk/TracingModel.js View 1 chunk +0 lines, -836 lines 0 comments Download
A + Source/devtools/front_end/timeline/TracingModel.js View 2 chunks +0 lines, -165 lines 0 comments Download
M Source/devtools/front_end/timeline/module.json View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
caseq
This is a follow-up to https://codereview.chromium.org/557013005/
6 years, 3 months ago (2014-09-10 15:42:03 UTC) #2
loislo
lgtm
6 years, 3 months ago (2014-09-11 06:30:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563463003/1
6 years, 3 months ago (2014-09-11 06:30:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/14921)
6 years, 3 months ago (2014-09-11 06:38:22 UTC) #7
yurys
lgtm https://codereview.chromium.org/563463003/diff/1/Source/devtools/front_end/sdk/TracingManager.js File Source/devtools/front_end/sdk/TracingManager.js (right): https://codereview.chromium.org/563463003/diff/1/Source/devtools/front_end/sdk/TracingManager.js#newcode2 Source/devtools/front_end/sdk/TracingManager.js:2: * Copyright 2014 The Chromium Authors. All rights ...
6 years, 3 months ago (2014-09-11 06:49:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563463003/1
6 years, 3 months ago (2014-09-11 06:52:53 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 07:12:27 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181797

Powered by Google App Engine
This is Rietveld 408576698