run-bindings-tests should use 'core' or 'modules' as component_dir.

run-bindings-tests should use 'core' or 'modules' as component_dir.

Before applying this patch, run-bindings-tests uses 'tests' as component_dir.
So tests results had '#include "bindings/tests/.../V8Test....h".

However, for testing binding modularization, need to emluate 'Source/core' and 'Source/modules'.
So Source/bindings/tests/idls/core should be treated as 'core' (i.e. the tests should be treated as if they are placed under Source/core).
Souce/bindings/tests/idsl/modules should be treated as 'modules'.

BUG=358074
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181875

[tasak, 2014-09-10 10:48:36]

tasak@google.com changed reviewers:
+ bashi@chromium.org, haraken@chromium.org

[tasak, 2014-09-10 10:48:36]

Would you review this CL?

[haraken, 2014-09-10 11:16:50]

https://codereview.chromium.org/563453002/diff/20001/Tools/Scripts/webkitpy/b...
File Tools/Scripts/webkitpy/bindings/main.py (right):

https://codereview.chromium.org/563453002/diff/20001/Tools/Scripts/webkitpy/b...
Tools/Scripts/webkitpy/bindings/main.py:95: COMPONENT_PATH_PATTERN =
re.compile(r'/(core|modules)(/|$)')

How about using re.compile(r'/(core|modules|tests)(/|$)') ?

[bashi, 2014-09-10 11:22:54]

https://codereview.chromium.org/563453002/diff/20001/Tools/Scripts/webkitpy/b...
File Tools/Scripts/webkitpy/bindings/main.py (right):

https://codereview.chromium.org/563453002/diff/20001/Tools/Scripts/webkitpy/b...
Tools/Scripts/webkitpy/bindings/main.py:100: if match:
When this check fails?

https://codereview.chromium.org/563453002/diff/20001/Tools/Scripts/webkitpy/b...
Tools/Scripts/webkitpy/bindings/main.py:138: # TestDictionary.{h,cpp} are placed
under Source/bindings/tests/idls/core.
This is a bit hacky. Passing output_directory (not output_dir) to
dictionary_impl_compiler won't work?

[tasak, 2014-09-11 02:52:02]

Thank you for reviewing.

https://codereview.chromium.org/563453002/diff/20001/Tools/Scripts/webkitpy/b...
File Tools/Scripts/webkitpy/bindings/main.py (right):

https://codereview.chromium.org/563453002/diff/20001/Tools/Scripts/webkitpy/b...
Tools/Scripts/webkitpy/bindings/main.py:95: COMPONENT_PATH_PATTERN =
re.compile(r'/(core|modules)(/|$)')
On 2014/09/10 11:16:50, haraken wrote:
> 
> How about using re.compile(r'/(core|modules|tests)(/|$)') ?

So are you talking about the below fallback code?

https://codereview.chromium.org/563453002/diff/20001/Tools/Scripts/webkitpy/b...
Tools/Scripts/webkitpy/bindings/main.py:100: if match:
On 2014/09/10 11:22:54, bashi1 wrote:
> When this check fails?

Currently all code passes.

However, I this, we need fallback code.

https://codereview.chromium.org/563453002/diff/20001/Tools/Scripts/webkitpy/b...
Tools/Scripts/webkitpy/bindings/main.py:138: # TestDictionary.{h,cpp} are placed
under Source/bindings/tests/idls/core.
On 2014/09/10 11:22:54, bashi1 wrote:
> This is a bit hacky. Passing output_directory (not output_dir) to
> dictionary_impl_compiler won't work?

I'm not sure why CodeGeneratorDictionaryImpl does the following:

        if interface_info['component_dir'] in KNOWN_COMPONENTS:
            output_dir = posixpath.join(self.output_dir,
                                        interface_info['relative_dir'])
        else:
            output_dir = self.output_dir

My change changes run-bindings-tests to use KNOWN_COMPONENTS (i.e. 'tests' =>
'core' or 'modules').

So dictionary_impl_compiler doesn't work.

[tasak, 2014-09-11 05:55:24]

https://codereview.chromium.org/563453002/diff/20001/Tools/Scripts/webkitpy/b...
File Tools/Scripts/webkitpy/bindings/main.py (right):

https://codereview.chromium.org/563453002/diff/20001/Tools/Scripts/webkitpy/b...
Tools/Scripts/webkitpy/bindings/main.py:100: if match:
On 2014/09/11 02:52:01, tasak wrote:
> On 2014/09/10 11:22:54, bashi1 wrote:
> > When this check fails?
> 
> Currently all code passes.
> 
> However, I this, we need fallback code.

Now raise AssertionError if the check fails.

[haraken, 2014-09-11 06:29:32]

LGTM if bashi-san is OK with it.

[bashi, 2014-09-11 23:49:23]

On 2014/09/11 06:29:32, haraken wrote:
> LGTM if bashi-san is OK with it.

LGTM. sorry for the delay..

[tasak, 2014-09-12 03:36:32]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2014-09-12 03:36:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/563453002/40001

[commit-bot: I haz the power, 2014-09-12 04:38:13]

Committed patchset #3 (id:40001) as 181875