Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 563383003: Copy webkit's test_expectations* files over to content. (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 3 months ago
Reviewers:
Dirk Pranke, sky
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Copy webkit's test_expectations* files over to content. We need to make a copy of them first in order to keep Buildbot working. Only after this lands we can update the Buildbot code to use the new path. BUG=338338 TEST=None R=sky@chromium.org,dpranke@chromium.org Committed: https://crrev.com/4f941d6e3da964f40ef729de90e15b5f5f2944b4 Cr-Commit-Position: refs/heads/master@{#294842}

Patch Set 1 #

Patch Set 2 : rm test_expectations_w3c.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
A + content/test/PRESUBMIT.py View 2 chunks +9 lines, -3 lines 0 comments Download
A + content/test/test_expectations.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/test_expectations_chrome.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
tfarina
Part 1 -> Chromium side (see e-mail sent).
6 years, 3 months ago (2014-09-13 13:49:50 UTC) #1
Dirk Pranke
lgtm
6 years, 3 months ago (2014-09-14 22:38:08 UTC) #2
Dirk Pranke
On 2014/09/14 22:38:08, Dirk Pranke wrote: > lgtm Oh, note that we don't need test_expectations_w3c.txt ...
6 years, 3 months ago (2014-09-14 22:43:56 UTC) #3
tfarina
On 2014/09/14 22:43:56, Dirk Pranke wrote: > On 2014/09/14 22:38:08, Dirk Pranke wrote: > > ...
6 years, 3 months ago (2014-09-15 02:34:56 UTC) #4
sky
LGTM
6 years, 3 months ago (2014-09-15 15:42:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563383003/20001
6 years, 3 months ago (2014-09-15 15:50:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0caf9ced7f7c8c9046cf0760db7fbb86668eacf4
6 years, 3 months ago (2014-09-15 17:18:03 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 17:23:36 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4f941d6e3da964f40ef729de90e15b5f5f2944b4
Cr-Commit-Position: refs/heads/master@{#294842}

Powered by Google App Engine
This is Rietveld 408576698