Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 563373002: Always activate MojoApplicationHost (Closed)

Created:
6 years, 3 months ago by Hajime Morrita
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Always activate MojoApplicationHost Before this change, MojoApplicatioHost was activated only if some browser-side modules requested it. There was no way for renderer to activate it. This CL let MojoApplicationHost always get activated. Now renderer can request services it needs without its own activation flow. R=darin@chromium.org,tsepez@chromium.org TEST=none BUG=none Committed: https://crrev.com/bd0aa4dc467c10a4301e44084d8abbba92a35e56 Cr-Commit-Position: refs/heads/master@{#294969} Committed: https://crrev.com/2c0a563d3019940343e804c7e975bef1bd0f5b54 Cr-Commit-Position: refs/heads/master@{#297551} Committed: https://crrev.com/869f0b293620e33800662618bffcd738cdbdde38 Cr-Commit-Position: refs/heads/master@{#300021}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Landing #

Patch Set 3 : Re-landing #

Patch Set 4 : Re-landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -33 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/mojo/mojo_application_host.h View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/mojo/mojo_application_host.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 2 3 3 chunks +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 5 chunks +1 line, -22 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
Hajime Morrita
6 years, 3 months ago (2014-09-12 21:08:58 UTC) #1
darin (slow to review)
LGTM https://codereview.chromium.org/563373002/diff/1/content/browser/renderer_host/render_process_host_impl.cc File content/browser/renderer_host/render_process_host_impl.cc (left): https://codereview.chromium.org/563373002/diff/1/content/browser/renderer_host/render_process_host_impl.cc#oldcode651 content/browser/renderer_host/render_process_host_impl.cc:651: if (!mojo_application_host_->did_activate()) it turns out this was the ...
6 years, 3 months ago (2014-09-15 04:49:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563373002/20001
6 years, 3 months ago (2014-09-15 18:02:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as bb7ad959821ff7fb56724f484559966e0b66fbb2
6 years, 3 months ago (2014-09-16 01:54:40 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/bd0aa4dc467c10a4301e44084d8abbba92a35e56 Cr-Commit-Position: refs/heads/master@{#294969}
6 years, 3 months ago (2014-09-16 02:02:18 UTC) #8
Hajime Morrita
The change was reverted https://codereview.chromium.org/584173002/ as it did crash.
6 years, 3 months ago (2014-09-22 16:54:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/563373002/40001
6 years, 2 months ago (2014-09-30 23:42:28 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as dd8f379e31c76ea58868b8d1b8c8374976f8a398
6 years, 2 months ago (2014-09-30 23:59:13 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/2c0a563d3019940343e804c7e975bef1bd0f5b54 Cr-Commit-Position: refs/heads/master@{#297551}
6 years, 2 months ago (2014-09-30 23:59:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/563373002/60001
6 years, 2 months ago (2014-10-16 21:55:58 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 2 months ago (2014-10-17 00:13:13 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 00:13:36 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/869f0b293620e33800662618bffcd738cdbdde38
Cr-Commit-Position: refs/heads/master@{#300021}

Powered by Google App Engine
This is Rietveld 408576698