Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: components/enhanced_bookmarks/enhanced_bookmark_model.h

Issue 563363002: Only set remote id during url node creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Tests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/enhanced_bookmarks/enhanced_bookmark_model.h
diff --git a/components/enhanced_bookmarks/enhanced_bookmark_model.h b/components/enhanced_bookmarks/enhanced_bookmark_model.h
index d89f07f78960f9300b600a5ca1a0d5296c9978af..eb85c1c3449d2f585c2f19084b7520204b81fa03 100644
--- a/components/enhanced_bookmarks/enhanced_bookmark_model.h
+++ b/components/enhanced_bookmarks/enhanced_bookmark_model.h
@@ -8,7 +8,6 @@
#include <string>
#include "base/strings/string16.h"
-#include "components/bookmarks/browser/bookmark_node.h"
#include "components/keyed_service/core/keyed_service.h"
namespace base {
@@ -16,6 +15,7 @@ class Time;
} // namespace base
class BookmarkModel;
+class BookmarkNode;
class GURL;
namespace enhanced_bookmarks {
@@ -105,16 +105,11 @@ class EnhancedBookmarkModel : public KeyedService {
BookmarkModel* bookmark_model() { return bookmark_model_; }
private:
- // Generates and sets a remote id for the given bookmark |node|.
- // Returns the id set.
- std::string SetRemoteId(const BookmarkNode* node);
-
// Helper method for setting a meta info field on a node. Also updates the
- // version and userEdits fields.
+ // version field.
void SetMetaInfo(const BookmarkNode* node,
const std::string& field,
- const std::string& value,
- bool user_edit);
+ const std::string& value);
// Returns the version string to use when setting stars.version.
std::string GetVersionString();

Powered by Google App Engine
This is Rietveld 408576698