Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 56333005: Update printing_context_win_unittest.cc for r231501. (Closed)

Created:
7 years, 1 month ago by bungeman-chromium
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Update printing_context_win_unittest.cc for r231501. r231501 changed PrintSettings::ranges from a field to a method. This updates a test to reflect this. R=vitalybuka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232466

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M printing/printing_context_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
bungeman-chromium
I'm somewhat interested in why this doesn't seem to show up anywhere. Is this file ...
7 years, 1 month ago (2013-11-01 20:28:42 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm yes. see issue 312495
7 years, 1 month ago (2013-11-01 21:04:56 UTC) #2
Vitaly Buka (NO REVIEWS)
On 2013/11/01 21:04:56, Vitaly Buka wrote: > lgtm > > yes. see issue 312495 crbug.com/312495
7 years, 1 month ago (2013-11-01 21:06:21 UTC) #3
bungeman-chromium
7 years, 1 month ago (2013-11-01 21:16:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r232466 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698