[Password Manager] Unfriend PasswordAutofillAgentTest from PasswordAutofillAgent (clean-up).

components/autofill/content/renderer/password_autofill_agent.h

Index: components/autofill/content/renderer/password_autofill_agent.h
diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h
index b6ab805249072b320e82ee9c9fa01dbc0b81acc1..c9f8a814cf441f13ec81ccef97f5fae9af0838c7 100644
--- a/components/autofill/content/renderer/password_autofill_agent.h
+++ b/components/autofill/content/renderer/password_autofill_agent.h
@@ -72,9 +72,16 @@ class PasswordAutofillAgent : public content::RenderViewObserver {
   virtual bool OriginCanAccessPasswordManager(
       const blink::WebSecurityOrigin& origin);
 
- private:
-  friend class PasswordAutofillAgentTest;
+  // Scans the given frame for password forms and sends them up to the browser.
+  // If |only_visible| is true, only forms visible in the layout are sent.
+  virtual void SendPasswordForms(blink::WebFrame* frame, bool only_visible);

[Ilya Sherman, 2014/09/18 18:45:53]

This is correctly a private method.  Please instead fix the tests to call
methods that are part of the public API for this class.

[Pritam Nikam, 2014/09/19 11:08:03]

Done.

+
+  // RenderViewObserver:
+  virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
+  virtual void WillSubmitForm(blink::WebLocalFrame* frame,
+                              const blink::WebFormElement& form) OVERRIDE;
 
+ private:
   enum OtherPossibleUsernamesUsage {
     NOTHING_TO_AUTOFILL,
     OTHER_POSSIBLE_USERNAMES_ABSENT,
@@ -134,7 +141,6 @@ class PasswordAutofillAgent : public content::RenderViewObserver {
   };
 
   // RenderViewObserver:

[Ilya Sherman, 2014/09/18 18:45:53]

Here, too, please increase the visibility of all of the RenderViewObserver
methods, or none of them.

[Pritam Nikam, 2014/09/19 11:08:03]

Done.

-  virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
   virtual void DidStartProvisionalLoad(blink::WebLocalFrame* frame) OVERRIDE;
   virtual void DidStartLoading() OVERRIDE;
   virtual void DidFinishDocumentLoad(blink::WebLocalFrame* frame) OVERRIDE;
@@ -144,17 +150,11 @@ class PasswordAutofillAgent : public content::RenderViewObserver {
   virtual void FrameWillClose(blink::WebFrame* frame) OVERRIDE;
   virtual void WillSendSubmitEvent(blink::WebLocalFrame* frame,
                                    const blink::WebFormElement& form) OVERRIDE;
-  virtual void WillSubmitForm(blink::WebLocalFrame* frame,
-                              const blink::WebFormElement& form) OVERRIDE;
 
   // RenderView IPC handlers:
   void OnFillPasswordForm(const PasswordFormFillData& form_data);
   void OnSetLoggingState(bool active);
 
-  // Scans the given frame for password forms and sends them up to the browser.
-  // If |only_visible| is true, only forms visible in the layout are sent.
-  void SendPasswordForms(blink::WebFrame* frame, bool only_visible);
-
   void GetSuggestions(const PasswordFormFillData& fill_data,
                       const base::string16& input,
                       std::vector<base::string16>* suggestions,