chrome/chrome_tests.gypi - Issue 563313004: [Password Manager] Unfriend PasswordAutofillAgentTest from PasswordAutofillAgent (clean-up).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_tests.gypi

Issue 563313004: [Password Manager] Unfriend PasswordAutofillAgentTest from PasswordAutofillAgent (clean-up). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_tests.gypi

diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi

index df75d186c4eb4a55a3c377e53d5e518ed6dc36cc..b3a63ccfe8c8ccea45997717980f3ff259e39acc 100644

--- a/chrome/chrome_tests.gypi

+++ b/chrome/chrome_tests.gypi

@@ -874,6 +874,8 @@

# TODO(blundell): Bring up a components_browsertests target and move

# this test to be in that target. crbug.com/283846

'../components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc',

+ '../components/autofill/content/renderer/test_autofill_agent.h',

+ '../components/autofill/content/renderer/test_autofill_agent.cc',

Ilya Sherman 2014/09/18 18:45:52 nit: Please alphabetize.

Pritam Nikam 2014/09/19 11:08:02 Done. Removed test_autofill_agent.h/cc as not req

'../components/autofill/content/renderer/test_password_autofill_agent.h',

'../components/autofill/content/renderer/test_password_autofill_agent.cc',

'../components/autofill/content/renderer/test_password_generation_agent.h',

@@ -2172,6 +2174,8 @@

'HAS_OUT_OF_PROC_TEST_RUNNER',

'sources': [

+ '../components/autofill/content/renderer/test_autofill_agent.h',

+ '../components/autofill/content/renderer/test_autofill_agent.cc',

'../components/autofill/content/renderer/test_password_autofill_agent.cc',

'../components/autofill/content/renderer/test_password_autofill_agent.h',

'../components/autofill/content/renderer/test_password_generation_agent.cc',

« no previous file with comments | « no previous file | chrome/chrome_tests_unit.gypi » ('j') | chrome/renderer/autofill/password_autofill_agent_browsertest.cc » ('J')