[Password Manager] Unfriend PasswordAutofillAgentTest from PasswordAutofillAgent (clean-up).

components/autofill/content/renderer/test_autofill_agent.h

Index: components/autofill/content/renderer/test_autofill_agent.h
diff --git a/components/autofill/content/renderer/test_autofill_agent.h b/components/autofill/content/renderer/test_autofill_agent.h
new file mode 100644
index 0000000000000000000000000000000000000000..fa3cd884a7ffa520e769a026e0bc27d84f5ae4bd
--- /dev/null
+++ b/components/autofill/content/renderer/test_autofill_agent.h
@@ -0,0 +1,51 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_TEST_AUTOFILL_AGENT_H_
+#define COMPONENTS_AUTOFILL_CONTENT_RENDERER_TEST_AUTOFILL_AGENT_H_
+
+#include "components/autofill/content/renderer/autofill_agent.h"
+
+namespace content {
+class RenderView;
+}
+
+namespace autofill {
+
+class PasswordAutofillAgent;
+class PasswordGenerationAgent;
+
+class TestAutofillAgent : public AutofillAgent {
+ public:
+  TestAutofillAgent(content::RenderView* render_view,
+                    PasswordAutofillAgent* password_autofill_manager,
+                    PasswordGenerationAgent* password_generation_agent);
+  virtual ~TestAutofillAgent();
+
+  // AutofillAgent:
+  virtual void FormControlElementClicked(
+      const blink::WebFormControlElement& element,
+      bool was_focused) OVERRIDE;
+  virtual void textFieldDidEndEditing(
+      const blink::WebInputElement& element) OVERRIDE;
+  virtual void textFieldDidChange(
+      const blink::WebFormControlElement& element) OVERRIDE;
+  virtual void textFieldDidReceiveKeyDown(
+      const blink::WebInputElement& element,
+      const blink::WebKeyboardEvent& event) OVERRIDE;
+  virtual void didRequestAutocomplete(
+      const blink::WebFormElement& form) OVERRIDE;
+
+  virtual void OnFillPasswordSuggestion(

[vabr (Chromium), 2014/09/15 14:26:59]

Instead of re-defining the methods and calling the parent, use 'using'. Here it
would be just:

using AutofillAgent::OnFillPasswordSuggestion;

The same holds for other methods declared here and in
test_password_autofill_agent.h.

[tfarina, 2014/09/15 16:23:36]

are you suggesting to use "using ..." in the header file? If yes, please, don't.

[Pritam Nikam, 2014/09/16 07:54:20]

Done.

+      const base::string16& username,
+      const base::string16& password) OVERRIDE;
+  virtual void OnRequestAutocompleteResult(
+      blink::WebFormElement::AutocompleteResult result,
+      const base::string16& message,
+      const FormData& form_data) OVERRIDE;
+};
+
+}  // namespace autofill
+
+#endif  // COMPONENTS_AUTOFILL_CONTENT_RENDERER_TEST_AUTOFILL_AGENT_H_