[Password Manager] Unfriend PasswordAutofillAgentTest from PasswordAutofillAgent (clean-up).

chrome/renderer/autofill/password_generation_agent_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string.h>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/test/base/chrome_render_view_test.h"
 #include "components/autofill/content/common/autofill_messages.h"
@@ skipping 182 matching lines @@
   password_generation_->OnMessageReceived(msg);
 
   // Passwords start out the same.
   EXPECT_EQ(password, first_password_element.value());
   EXPECT_EQ(password, second_password_element.value());
 
   // After editing the first field they are still the same.
   base::string16 edited_password = base::ASCIIToUTF16("edited_password");
   first_password_element.setValue(edited_password);
   // Cast to WebAutofillClient where textFieldDidChange() is public.
-  static_cast<blink::WebAutofillClient*>(autofill_agent_)->textFieldDidChange(
-      first_password_element);
+  AutofillAgent* autofill_agent = (AutofillAgent*)autofill_agent_;

[vabr (Chromium), 2014/09/15 14:26:59]

Don't use C-style cast, use one of C++ casts.
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Casting)
Here the appropriate one seems to be static_cast, except I don't understand why
do you need the change to 2-step cast at all -- does the old code not work?

Also below.

[Pritam Nikam, 2014/09/16 07:54:19]

Done.
I've missed including header earlier.

+  static_cast<blink::WebAutofillClient*>(autofill_agent)
+      ->textFieldDidChange(first_password_element);
   // textFieldDidChange posts a task, so we need to wait until it's been
   // processed.
   base::MessageLoop::current()->RunUntilIdle();
 
   EXPECT_EQ(edited_password, first_password_element.value());
   EXPECT_EQ(edited_password, second_password_element.value());
 }
 
 TEST_F(PasswordGenerationAgentTest, BlacklistedTest) {
   // Did not receive not blacklisted message. Don't show password generation
@@ skipping 50 matching lines @@
   WebElement element =
       document.getElementById(WebString::fromUTF8("first_password"));
   ASSERT_FALSE(element.isNull());
   WebInputElement first_password_element = element.to<WebInputElement>();
 
   // Make a password just under maximum offer size.
   first_password_element.setValue(
       base::ASCIIToUTF16(
           std::string(password_generation_->kMaximumOfferSize - 1, 'a')));
   // Cast to WebAutofillClient where textFieldDidChange() is public.
-  static_cast<blink::WebAutofillClient*>(autofill_agent_)->textFieldDidChange(
-      first_password_element);
+  AutofillAgent* autofill_agent = (AutofillAgent*)autofill_agent_;
+  static_cast<blink::WebAutofillClient*>(autofill_agent)
+      ->textFieldDidChange(first_password_element);
   // textFieldDidChange posts a task, so we need to wait until it's been
   // processed.
   base::MessageLoop::current()->RunUntilIdle();
   // There should now be a message to show the UI.
   ASSERT_EQ(1u, password_generation_->messages().size());
   EXPECT_EQ(AutofillHostMsg_ShowPasswordGenerationPopup::ID,
             password_generation_->messages()[0]->type());
   password_generation_->clear_messages();
 
   // Simulate a user typing a password just over maximum offer size.
   first_password_element.setValue(
       base::ASCIIToUTF16(
           std::string(password_generation_->kMaximumOfferSize + 1, 'a')));
   // Cast to WebAutofillClient where textFieldDidChange() is public.
-  static_cast<blink::WebAutofillClient*>(autofill_agent_)->textFieldDidChange(
-      first_password_element);
+  static_cast<blink::WebAutofillClient*>(autofill_agent)
+      ->textFieldDidChange(first_password_element);
   // textFieldDidChange posts a task, so we need to wait until it's been
   // processed.
   base::MessageLoop::current()->RunUntilIdle();
   // There should now be a message to hide the UI.
   ASSERT_EQ(1u, password_generation_->messages().size());
   EXPECT_EQ(AutofillHostMsg_HidePasswordGenerationPopup::ID,
             password_generation_->messages()[0]->type());
   password_generation_->clear_messages();
 
   // Simulate the user deleting characters. The generation popup should be shown
   // again.
   first_password_element.setValue(
       base::ASCIIToUTF16(
           std::string(password_generation_->kMaximumOfferSize, 'a')));
   // Cast to WebAutofillClient where textFieldDidChange() is public.
-  static_cast<blink::WebAutofillClient*>(autofill_agent_)->textFieldDidChange(
-      first_password_element);
+  static_cast<blink::WebAutofillClient*>(autofill_agent)
+      ->textFieldDidChange(first_password_element);
   // textFieldDidChange posts a task, so we need to wait until it's been
   // processed.
   base::MessageLoop::current()->RunUntilIdle();
   // There should now be a message to show the UI.
   ASSERT_EQ(1u, password_generation_->messages().size());
   EXPECT_EQ(AutofillHostMsg_ShowPasswordGenerationPopup::ID,
             password_generation_->messages()[0]->type());
   password_generation_->clear_messages();
 
   // Change focus. Bubble should be hidden, but that is handled by AutofilAgent,
   // so no messages are sent.
   ExecuteJavaScript("document.getElementById('username').focus();");
   EXPECT_EQ(0u, password_generation_->messages().size());
   password_generation_->clear_messages();
 
   // Focusing the password field will bring up the generation UI again.
   ExecuteJavaScript("document.getElementById('first_password').focus();");
   EXPECT_EQ(1u, password_generation_->messages().size());
   EXPECT_EQ(AutofillHostMsg_ShowPasswordGenerationPopup::ID,
             password_generation_->messages()[0]->type());
   password_generation_->clear_messages();
 }
 
 }  // namespace autofill