Subzero: Always be sure x87 FP stack is emptied after a call.

Subzero: Always be sure x87 FP stack is emptied after a call.

In x86-32, floating point values are returned to the caller on the top of the x87 floating point stack.  The caller is required to remove it from the x87 FP stack, e.g. via the fstp instruction.

This must be done even when the return value is not actually used anywhere else in the function, in which case O2 is likely to want to dead-code eliminate the fstp instruction.

We enforce this by adding a fake use of the fstp destination.

BUG= none
R=jvoung@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a522972

[Jim Stichnoth, 2014-09-12 19:22:35]

stichnot@chromium.org changed reviewers:
+ jvoung@chromium.org

[Jim Stichnoth, 2014-09-12 19:24:18]

This fix allows 253.perlbmk to run under O2.

[jvoung (off chromium), 2014-09-12 19:44:01]

lgtm

[Jim Stichnoth, 2014-09-12 20:06:14]

Committed patchset #1 (id:1) manually as a522972 (tree was closed).