Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 563303002: Switch to llvm::findFirstSet instead of ffs since mingw doesn't have ffs. (Closed)

Created:
6 years, 3 months ago by jvoung (off chromium)
Modified:
6 years, 3 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Switch to llvm::findFirstSet instead of ffs since mingw doesn't have ffs. ffs() vs findFirstSet() are slightly different, indexing is 0-based instead of 1-based. Example mingw error: http://build.chromium.org/p/tryserver.nacl/builders/nacl-toolchain-win7-pnacl-x86_64/builds/1920/steps/llvm_i686_w64_mingw32%20%28build%29/logs/stdio BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=1eb3a55dd9a08ceffe545b144a3be9ba63955035

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/IceTargetLoweringX8632.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jvoung (off chromium)
6 years, 3 months ago (2014-09-12 17:44:20 UTC) #2
Jim Stichnoth
lgtm
6 years, 3 months ago (2014-09-12 17:49:22 UTC) #3
jvoung (off chromium)
6 years, 3 months ago (2014-09-12 18:05:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 1eb3a55 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698