This change contains changes that were made on a separate copy of this code,...

src/trusted/gdb_rsp/packet.cc

Index: src/trusted/gdb_rsp/packet.cc
===================================================================
--- src/trusted/gdb_rsp/packet.cc	(revision 3879)
+++ src/trusted/gdb_rsp/packet.cc	(working copy)
@@ -266,6 +266,8 @@
   if (!GetRawChar(&seq1)) return false;
   if (!GetRawChar(&seq2)) return false;
 

[noelallen_use_chromium, 2010/12/07 23:04:44]

This looks like it should be removed.  Accidental debugging spew from
development?

[mlinck, 2010/12/10 21:10:27]

Done.

+  printf("GetWord8 got chars: %c %c\n", seq1, seq2);

[mmortensen, 2010/12/07 22:53:58]

Having the printf is probably a big help here, since it's hard to debug the
debugger.  Two questions:
   1) Do we need to guard them with a boolean variable or ifdefs?
   2) Should other functions (GetWord16, GetWord32) also consistently printf for
debug help?

I'm not sure the answer to the questions, but it's worth thinking about while
you are in the code.

[mlinck, 2010/12/10 21:10:27]

removed this

+
   // Convert them to ints
   if (!NibbleToInt(seq1, &val1)) return false;
   if (!NibbleToInt(seq2, &val2)) return false;
@@ -299,6 +301,7 @@
 }
 
 bool Packet::GetWord64(uint64_t *ptr) {
+  printf("GetWord64 running \n");

[noelallen_use_chromium, 2010/12/07 23:04:44]

same.

[mlinck, 2010/12/10 21:10:27]

Done.

   assert(ptr);
   return GetBlock(ptr, sizeof(*ptr));
 }