This change contains changes that were made on a separate copy of this code,...

src/trusted/gdb_rsp/host.cc

Index: src/trusted/gdb_rsp/host.cc
===================================================================
--- src/trusted/gdb_rsp/host.cc	(revision 3879)
+++ src/trusted/gdb_rsp/host.cc	(working copy)
@@ -240,8 +240,9 @@
 
 // Wait to see if we receive a break
 bool Host::WaitForBreak() {

[noelallen_use_chromium, 2010/12/07 23:04:44]

Should we kill HS_STOPPING?

[mlinck, 2010/12/10 21:10:27]

A break request results in the "stopping" state. To wait for a break is valid if
status == hs_stopping.  I'm not sure if hs_running is still a necessary check
here but I'd want to make sure I have written test coverage for this before
modifying it further.  (note that I didn't make this change originally)

-  // We can not wait if we are not running
-  if (HS_RUNNING != status_) return false;
+  // We can not wait if we are already stopped
+  if (HS_RUNNING != status_
+    && HS_STOPPING != status_) return false;
 
   Packet rx;
   std::string str;