Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 563283003: Revert r23916, r23917 for breaking 64-bit tests. (Closed)

Created:
6 years, 3 months ago by ulan
Modified:
6 years, 3 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Revert r23916, r23917 for breaking 64-bit tests. "Use unsigned type bitsets to limit undefined behaviour". TBR=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23922

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -174 lines) Patch
M src/types.h View 11 chunks +76 lines, -76 lines 0 comments Download
M src/types.cc View 20 chunks +50 lines, -59 lines 0 comments Download
M src/types-inl.h View 5 chunks +11 lines, -14 lines 0 comments Download
M test/cctest/test-types.cc View 10 chunks +19 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
ulan
PTAL
6 years, 3 months ago (2014-09-12 16:09:29 UTC) #2
ulan
6 years, 3 months ago (2014-09-12 16:13:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23922 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698